From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HU1Ew-0003fa-1h
	for qemu-devel@nongnu.org; Wed, 21 Mar 2007 09:52:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HU1Ev-0003dE-6s
	for qemu-devel@nongnu.org; Wed, 21 Mar 2007 09:52:33 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HU1Ev-0003ct-3Q
	for qemu-devel@nongnu.org; Wed, 21 Mar 2007 08:52:33 -0500
Received: from grayson.netsweng.com ([207.235.77.11])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anderson@netsweng.com>) id 1HU1DE-0007tJ-AQ
	for qemu-devel@nongnu.org; Wed, 21 Mar 2007 09:50:48 -0400
Received: from amavis by grayson.netsweng.com with scanned-ok (Exim 3.36 #1
	(Debian)) id 1HU1DD-0007pp-00
	for <qemu-devel@nongnu.org>; Wed, 21 Mar 2007 09:50:47 -0400
Received: from grayson.netsweng.com ([127.0.0.1])
	by localhost (grayson.netsweng.com [127.0.0.1]) (amavisd-new,
	port 10024) with ESMTP id X2L-SrUVvegv for <qemu-devel@nongnu.org>;
	Wed, 21 Mar 2007 09:50:17 -0400 (EDT)
Received: from h211.241.141.67.ip.alltel.net ([67.141.241.211]
	helo=trantor.stuart.netsweng.com)
	by grayson.netsweng.com with esmtp (Exim 3.36 #1 (Debian))
	id 1HU1Cj-0007jJ-00
	for <qemu-devel@nongnu.org>; Wed, 21 Mar 2007 09:50:17 -0400
Date: Wed, 21 Mar 2007 09:49:51 -0400 (EDT)
From: Stuart Anderson <anderson@netsweng.com>
Subject: Re: [Qemu-devel] [PATCH] fcntl64 fix
In-Reply-To: <20070320225957.GB32229@localhost.localdomain>
Message-ID: <Pine.LNX.4.64.0703210930590.12505@trantor.stuart.netsweng.com>
References: <20070320114315.GA26019@localhost.localdomain>
	<Pine.LNX.4.64.0703200954000.12505@trantor.stuart.netsweng.com>
	<20070320135910.GA18571@localhost.localdomain>
	<Pine.LNX.4.64.0703201252460.12505@trantor.stuart.netsweng.com>
	<20070320171103.GA20530@localhost.localdomain>
	<Pine.LNX.4.64.0703201358190.12505@trantor.stuart.netsweng.com>
	<20070320193442.GA11933@localhost.localdomain>
	<Pine.LNX.4.64.0703201625070.12505@trantor.stuart.netsweng.com>
	<Pine.LNX.4.64.0703201713390.12505@trantor.stuart.netsweng.com>
	<20070320214749.GE2311@networkno.de>
	<20070320225957.GB32229@localhost.localdomain>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, 21 Mar 2007, Kirill A. Shutemov wrote:

> Primarily, I also thought that problem is in padding, because, without the
> patch F_GETLK, on 32-bit target recognises as F_GETLK64 on 64-bit host.
> It's happen because on 64-bit host and 32-bit target F_GETLK == F_GETLK64 ==
> TARGET_F_GETLK. So if you're using qemu-arm on 64-bit host and a target eabi
> program calls fcntl(fd,F_GETLK,...), target_eabi_flock64 will be used by
> mistake. Disabling padding can helps in some trivial cases to pass
> pseudo-correct args to fcntl. I guess this part of patch wrong.
>
> Stuart, am I right?

Yes, this is a good summary of the trap I initially fell into.


                                   Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                    BD03 0A62 E534 37A7 9149