[Qemu-devel] [PATCH] PPC termios structure ordering

[Qemu-devel] [PATCH] PPC termios structure ordering

[Stuart Anderson]

Just found a small problem w/ the termios structure as defined for PPC
linux user. It doesn't match the one in include/asm-powerpc/termbits.h.

Index: linux-user/ppc/termbits.h
===================================================================
--- linux-user/ppc/termbits.h   (revision 44)
+++ linux-user/ppc/termbits.h   (working copy)
@@ -7,8 +7,8 @@
      unsigned int c_oflag;               /* output mode flags */
      unsigned int c_cflag;               /* control mode flags */
      unsigned int c_lflag;               /* local mode flags */
+    unsigned char c_cc[TARGET_NCCS];                /* control
characters */
      unsigned char c_line;                    /* line discipline */
-    unsigned char c_cc[TARGET_NCCS];                /* control
      characters */
      unsigned int c_ispeed;             /* input speed */
      unsigned int c_ospeed;             /* output speed */
  };


With this change, both host and target 'stty -a' give the same output.


                                 Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                  BD03 0A62 E534 37A7 9149

Re: [Qemu-devel] [PATCH] PPC termios structure ordering

[J. Mayer]

On Tue, 2007-04-17 at 16:20 -0400, Stuart Anderson wrote:
> Just found a small problem w/ the termios structure as defined for PPC
> linux user. It doesn't match the one in include/asm-powerpc/termbits.h.
> 
> Index: linux-user/ppc/termbits.h
> ===================================================================
> --- linux-user/ppc/termbits.h   (revision 44)
> +++ linux-user/ppc/termbits.h   (working copy)
> @@ -7,8 +7,8 @@
>       unsigned int c_oflag;               /* output mode flags */
>       unsigned int c_cflag;               /* control mode flags */
>       unsigned int c_lflag;               /* local mode flags */
> +    unsigned char c_cc[TARGET_NCCS];                /* control
> characters */
>       unsigned char c_line;                    /* line discipline */
> -    unsigned char c_cc[TARGET_NCCS];                /* control
>       characters */
>       unsigned int c_ispeed;             /* input speed */
>       unsigned int c_ospeed;             /* output speed */
>   };
> 
> 
> With this change, both host and target 'stty -a' give the same output.

Thanks. I'll take a better look to this patch then apply. There maybe
the same issue in the ppc64 strucutre ?

-- 
J. Mayer <l_indien@magic.fr>
Never organized

Re: [Qemu-devel] [PATCH] PPC termios structure ordering

[Stuart Anderson]

On Wed, 18 Apr 2007, J. Mayer wrote:

>> With this change, both host and target 'stty -a' give the same output.
>
> Thanks. I'll take a better look to this patch then apply. There maybe
> the same issue in the ppc64 strucutre ?

Yes, it looks like the same changes it needed in linux-user/ppc64/termbits.h
as well.


                                 Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                  BD03 0A62 E534 37A7 9149