From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1I6r67-0003a0-Gs
	for qemu-devel@nongnu.org; Fri, 06 Jul 2007 12:55:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1I6r65-0003ZS-Hb
	for qemu-devel@nongnu.org; Fri, 06 Jul 2007 12:55:58 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1I6r65-0003ZP-C1
	for qemu-devel@nongnu.org; Fri, 06 Jul 2007 12:55:57 -0400
Received: from grayson.netsweng.com ([207.235.77.11])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anderson@netsweng.com>) id 1I6r64-0004Cz-Kg
	for qemu-devel@nongnu.org; Fri, 06 Jul 2007 12:55:56 -0400
Received: from amavis by grayson.netsweng.com with scanned-ok (Exim 3.36 #1
	(Debian)) id 1I6r63-00057M-00
	for <qemu-devel@nongnu.org>; Fri, 06 Jul 2007 12:55:55 -0400
Received: from grayson.netsweng.com ([127.0.0.1])
	by localhost (grayson.netsweng.com [127.0.0.1]) (amavisd-new,
	port 10024) with ESMTP id h1brU9V9zS+R for <qemu-devel@nongnu.org>;
	Fri,  6 Jul 2007 12:55:39 -0400 (EDT)
Received: from h150.93.213.151.ip.alltel.net ([151.213.93.150]
	helo=trantor.stuart.netsweng.com)
	by grayson.netsweng.com with esmtp (Exim 3.36 #1 (Debian))
	id 1I6r5m-00052e-00
	for <qemu-devel@nongnu.org>; Fri, 06 Jul 2007 12:55:38 -0400
Date: Fri, 6 Jul 2007 12:55:15 -0400 (EDT)
From: Stuart Anderson <anderson@netsweng.com>
Subject: Re: [Qemu-devel] [PATCH] linux-user EFAULT implementation
In-Reply-To: <468E68F7.8070005@bellard.org>
Message-ID: <Pine.LNX.4.64.0707061253470.12799@trantor.stuart.netsweng.com>
References: <Pine.LNX.4.64.0707061111150.12799@trantor.stuart.netsweng.com>
	<468E68F7.8070005@bellard.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, 6 Jul 2007, Fabrice Bellard wrote:

> Please update page_check_range() (and other related functions) to return 
> -EFAULT instead of EFAULT in case of error.

Will do.


> Moreover, I believe using similar functions as Linux for memory access 
> (copyfromuser, copytouser, get_user, put_user) would be cleaner.

This makes sense. That code that I sent was based on the idea that I was
just extending the model that was already there, instead of giving it a
complete overhaul. I'll look into how much work the overhaul would be.


                                 Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                  BD03 0A62 E534 37A7 9149