qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stuart Anderson <anderson@c2.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user EFAULT implementation
Date: Tue, 10 Jul 2007 17:09:20 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707101702540.28322@trantor.stuart.netsweng.com> (raw)
In-Reply-To: <4693EFDC.3080604@bellard.org>

On Tue, 10 Jul 2007, Fabrice Bellard wrote:

> I confirm that I expected g2h() to be completely removed in case the Linux 
> user access API is used.

I agree too that it should not be used. I'm testing ARM on x86_64, and
used it in a few places to clean up some warnings. The real fix is to
change what I was doing to not need this asignment anyway. I will take
another look at how to bury this part in the copy* interfaces.

Would it be OK to use g2h() inside the implementation of copy* ?

> Since you agree for the copying interface, I suggest to convert all the code 
> to it.

OK, I'll continue in this direction, after taking a fresh look at what I
did yesterday.

Thanks for the feedback.


                                 Stuart

Stuart R. Anderson                               anderson@c2.net
Solutions Architect                              http://www.c2.net/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                  BD03 0A62 E534 37A7 9149

  reply	other threads:[~2007-07-10 21:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-06 15:15 [Qemu-devel] [PATCH] linux-user EFAULT implementation Stuart Anderson
2007-07-06 16:08 ` Fabrice Bellard
2007-07-06 16:55   ` Stuart Anderson
2007-07-06 18:45     ` Stuart Anderson
2007-07-09 11:41       ` Stuart Anderson
2007-07-09 12:02         ` Stuart Anderson
2007-07-09 21:15         ` Fabrice Bellard
2007-07-10  2:22           ` Stuart Anderson
2007-07-10 12:38             ` Paul Brook
2007-07-10 20:45               ` Fabrice Bellard
2007-07-10 21:09                 ` Stuart Anderson [this message]
2007-07-13 17:55                   ` Stuart Anderson
2007-07-20 20:16                     ` Stuart Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707101702540.28322@trantor.stuart.netsweng.com \
    --to=anderson@c2.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).