From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ICHnj-0006fv-VC
	for qemu-devel@nongnu.org; Sat, 21 Jul 2007 12:27:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ICHnj-0006f1-Cp
	for qemu-devel@nongnu.org; Sat, 21 Jul 2007 12:27:27 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ICHnj-0006em-3x
	for qemu-devel@nongnu.org; Sat, 21 Jul 2007 12:27:27 -0400
Received: from grayson.netsweng.com ([207.235.77.11])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anderson@netsweng.com>) id 1ICHni-0003Cz-Sk
	for qemu-devel@nongnu.org; Sat, 21 Jul 2007 12:27:26 -0400
Received: from amavis by grayson.netsweng.com with scanned-ok (Exim 3.36 #1
	(Debian)) id 1ICHni-0001JP-00
	for <qemu-devel@nongnu.org>; Sat, 21 Jul 2007 12:27:26 -0400
Received: from grayson.netsweng.com ([127.0.0.1])
	by localhost (grayson.netsweng.com [127.0.0.1]) (amavisd-new,
	port 10024) with ESMTP id Nu7Apxi5P1UB for <qemu-devel@nongnu.org>;
	Sat, 21 Jul 2007 12:27:04 -0400 (EDT)
Received: from [71.31.88.35] (helo=trantor.stuart.netsweng.com)
	by grayson.netsweng.com with esmtp (Exim 3.36 #1 (Debian))
	id 1ICHnL-0001Iv-00
	for <qemu-devel@nongnu.org>; Sat, 21 Jul 2007 12:27:04 -0400
Date: Sat, 21 Jul 2007 12:26:42 -0400 (EDT)
From: Stuart Anderson <anderson@netsweng.com>
Subject: Re: [Qemu-devel] [PATCH] linux-user strace
In-Reply-To: <jevecdu4me.fsf@sykes.suse.de>
Message-ID: <Pine.LNX.4.64.0707211222500.13035@trantor.stuart.netsweng.com>
References: <Pine.LNX.4.64.0707201501300.13035@trantor.stuart.netsweng.com>
	<jeejj2da8g.fsf@sykes.suse.de>
	<Pine.LNX.4.64.0707210907290.13035@trantor.stuart.netsweng.com>
	<jevecdu4me.fsf@sykes.suse.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, 21 Jul 2007, Andreas Schwab wrote:

> That's the problem.  It does not return the string associated with the
> target errno, but something else.

It depends on what is being passed in to it. Looking over it again this
morning, I can see some paths where it is passed the host errno, and
some paths where it is passed a target errno via "ret". So in the later
case, it would be double mapping the errno, which would be wrong.

I had suspected there may be a bit more work left in mapping errno values,
but I wasn't yet sure what was needed where. I'd like to clear up the use
of target_strerr() as part of that fix if that's ok with everyone.


                                 Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                  BD03 0A62 E534 37A7 9149