From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IQMqz-0006jZ-4R
	for qemu-devel@nongnu.org; Wed, 29 Aug 2007 08:41:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IQMqx-0006j2-DC
	for qemu-devel@nongnu.org; Wed, 29 Aug 2007 08:41:00 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IQMqx-0006iz-5K
	for qemu-devel@nongnu.org; Wed, 29 Aug 2007 08:40:59 -0400
Received: from mail.gmx.net ([213.165.64.20])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <Johannes.Schindelin@gmx.de>) id 1IQMqw-0001RM-Jy
	for qemu-devel@nongnu.org; Wed, 29 Aug 2007 08:40:58 -0400
Date: Wed, 29 Aug 2007 13:40:55 +0100 (BST)
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [Qemu-devel] [patch] make qemu work with GCC 4
In-Reply-To: <Pine.LNX.4.64.0708291340550.23011@wotan.suse.de>
Message-ID: <Pine.LNX.4.64.0708291337440.28586@racer.site>
References: <Pine.LNX.4.64.0708282124590.23011@wotan.suse.de>
	<Pine.LNX.4.64.0708291047070.28586@racer.site>
	<Pine.LNX.4.64.0708291340550.23011@wotan.suse.de>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="8323584-204687695-1188391255=:28586"
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Matz <matz@suse.de>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323584-204687695-1188391255=:28586
Content-Type: TEXT/PLAIN; charset=utf-8
Content-Transfer-Encoding: 8BIT

Hi,

On Wed, 29 Aug 2007, Michael Matz wrote:

> On Wed, 29 Aug 2007, Johannes Schindelin wrote:
> 
> > > The whole patch is against a 0.9.0-cvs version from 2007-07-09 (Alex 
> > > might know the exact checkout date), so chances are that it still 
> > > applies :)
> > 
> > It is based on the z80 fork, but it applies relatively cleanly (one 
> > trailing whitespace) to the version as of "Use unsigned 32-bit load 
> > for ld/lduw".
> > 
> > However, I still get this error:
> > 
> > ../dyngen -o op.h op.o
> > dyngen: ret or jmp expected at the end of op_tadd_T1_T0_ccTV
> > make[1]: *** [op.h] Fehler 1
> > make[1]: Leaving directory `/home/me/qemu/sparc-linux-user'
> 
> Using SuSE 10.2, i.e. gcc 4.1.2?

Yep.  It would be good to fix this error before applying the patch to CVS 
;-)

> > When only making i386-softmmu, I still get this (on SuSE 10.2):
> > 
> > In file included from /home/gene099/my/qemu/usb-linux.c:29:
> > /usr/include/linux/usbdevice_fs.h:49: error: expected ‘:’, ‘,’, ‘;’, ‘}’ 
> > or ‘__attribute__’ before ‘*’ token
> > [...]
> 
> Yes, that's a problem of the kernel headers on 10.2.  You can work 
> around this with the below snippet.

I did it differently now.

My changes can be seen (and fetched) at

	http://repo.or.cz/qemu/dscho.git/

in the "gcc4" branch.  This is just your patch applied to the revision I 
mentioned (which is available in the "gcc4-original" branch), then rebased 
onto current CVS (or what Jens Axboe's clone is current at right now).  I 
adjusted one target_ulong, and added another commit for the 
linux/compiler.h issue.

Ciao,
Dscho

--8323584-204687695-1188391255=:28586--