qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Ben Taylor <sol10x86@cox.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Comment for Solaris fix for the HPTC
Date: Sun, 16 Sep 2007 18:18:49 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0709161817400.28586@racer.site> (raw)
In-Reply-To: <26700091.1189955481400.JavaMail.root@eastrmwml11>

Hi,

On Sun, 16 Sep 2007, Ben Taylor wrote:

> ---- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: 
> 
> > On Sat, 15 Sep 2007, Ben Taylor wrote:
> > 
> > > +#ifdef __sun__
> > > +/* Have to define this for Solaris as ULONG_LONG_MAX is not defined
> > > +   anywhere.  ULONG_MAX is correct only on _LP64 systems */
> > > +#define ULONG_LONG_MAX 18446744073709551615UL
> > > +#endif
> > > +
> > 
> > These constants are always defined, right?  So why not "#ifndef 
> > ULONG_LONG_MAX"?
> 
> I fear I may not have explained this well.

I fear _I_ may not have made myself very clear.  What I meant was: why not 
check if ULONG_LONG_MAX is undefined, instead of checking if __sun__ is 
defined?  That way, more than one platform might benefit from this change.

Just an idea,
Dscho

  parent reply	other threads:[~2007-09-16 17:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-16 15:11 [Qemu-devel] Comment for Solaris fix for the HPTC Ben Taylor
2007-09-16 16:35 ` Andreas Schwab
2007-09-16 17:18 ` Johannes Schindelin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-09-17  9:12 Juergen Keil
2007-09-15 21:53 Ben Taylor
2007-09-15 22:23 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0709161817400.28586@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=sol10x86@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).