From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IWxmU-0001PD-Bo
	for qemu-devel@nongnu.org; Sun, 16 Sep 2007 13:19:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IWxmS-0001OE-38
	for qemu-devel@nongnu.org; Sun, 16 Sep 2007 13:19:37 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IWxmR-0001OB-Ty
	for qemu-devel@nongnu.org; Sun, 16 Sep 2007 13:19:35 -0400
Received: from mail.gmx.net ([213.165.64.20])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <Johannes.Schindelin@gmx.de>) id 1IWxmR-0004VF-FD
	for qemu-devel@nongnu.org; Sun, 16 Sep 2007 13:19:35 -0400
Date: Sun, 16 Sep 2007 18:18:49 +0100 (BST)
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [Qemu-devel] Comment for Solaris fix for the HPTC
In-Reply-To: <26700091.1189955481400.JavaMail.root@eastrmwml11>
Message-ID: <Pine.LNX.4.64.0709161817400.28586@racer.site>
References: <26700091.1189955481400.JavaMail.root@eastrmwml11>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ben Taylor <sol10x86@cox.net>
Cc: qemu-devel@nongnu.org

Hi,

On Sun, 16 Sep 2007, Ben Taylor wrote:

> ---- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: 
> 
> > On Sat, 15 Sep 2007, Ben Taylor wrote:
> > 
> > > +#ifdef __sun__
> > > +/* Have to define this for Solaris as ULONG_LONG_MAX is not defined
> > > +   anywhere.  ULONG_MAX is correct only on _LP64 systems */
> > > +#define ULONG_LONG_MAX 18446744073709551615UL
> > > +#endif
> > > +
> > 
> > These constants are always defined, right?  So why not "#ifndef 
> > ULONG_LONG_MAX"?
> 
> I fear I may not have explained this well.

I fear _I_ may not have made myself very clear.  What I meant was: why not 
check if ULONG_LONG_MAX is undefined, instead of checking if __sun__ is 
defined?  That way, more than one platform might benefit from this change.

Just an idea,
Dscho