From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Ivan Kalvachev <ikalvachev@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vvfat mbr fixes
Date: Sat, 22 Sep 2007 23:48:55 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0709222342190.28395@racer.site> (raw)
In-Reply-To: <219e947f0709221443l494e4c46w6efafce989dbb867@mail.gmail.com>
Hi,
On Sun, 23 Sep 2007, Ivan Kalvachev wrote:
> I've been having problems using vvfat virtual block device. Even linux
> fdisk was able to find problems with it. The reason turned out to be
> simple, MBR have bogus parameters.
Thanks for doing this; I did not find any time for that.
Overall, I like what you did, but here are some comments (if you would
have inlined the patch, I would have commented with references):
- I like the convert_sector2CHS() function, although I would have named it
sector2CHS() for brevity (although the pretty magic -- or unintuitive
-- detection if lba is needed would have to be done differently, which
I maintain would be better),
- you write the NT-ID byte-per-byte, whereas I would have used strcpy()
for clarity,
- I'd have introduced a member nt_id instead of hardcoding an offset into
the "ignored" part, and
- fat_type == 12 and lba does not make sense, or does it?
Thanks,
Dscho
next prev parent reply other threads:[~2007-09-22 22:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 21:43 [Qemu-devel] [PATCH] vvfat mbr fixes Ivan Kalvachev
2007-09-22 22:48 ` Johannes Schindelin [this message]
2007-09-23 7:31 ` [Qemu-devel] " Lorenzo Campedelli
2007-09-23 11:34 ` Johannes Schindelin
2007-09-23 15:55 ` Lorenzo Campedelli
2007-09-23 19:18 ` Johannes Schindelin
2007-09-23 20:17 ` Lorenzo Campedelli
2007-09-24 10:50 ` [Qemu-devel] " Ivan Kalvachev
2007-09-24 11:18 ` Johannes Schindelin
2007-09-24 14:12 ` Ivan Kalvachev
2007-09-24 15:32 ` Johannes Schindelin
2007-09-24 17:23 ` Ivan Kalvachev
2007-09-24 19:19 ` [Qemu-devel] " Lorenzo Campedelli
2007-09-24 21:58 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709222342190.28395@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=ikalvachev@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).