From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IZpwR-00077Q-JN
	for qemu-devel@nongnu.org; Mon, 24 Sep 2007 11:33:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IZpwP-00076L-0x
	for qemu-devel@nongnu.org; Mon, 24 Sep 2007 11:33:46 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IZpwO-00076G-RX
	for qemu-devel@nongnu.org; Mon, 24 Sep 2007 11:33:44 -0400
Received: from mail.gmx.net ([213.165.64.20])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <Johannes.Schindelin@gmx.de>) id 1IZpwO-0004MH-BL
	for qemu-devel@nongnu.org; Mon, 24 Sep 2007 11:33:44 -0400
Date: Mon, 24 Sep 2007 16:32:41 +0100 (BST)
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [Qemu-devel] [PATCH] vvfat mbr fixes
In-Reply-To: <219e947f0709240712q3b8ccdaej491f777fbdc76bce@mail.gmail.com>
Message-ID: <Pine.LNX.4.64.0709241630310.28395@racer.site>
References: <219e947f0709221443l494e4c46w6efafce989dbb867@mail.gmail.com>
	<Pine.LNX.4.64.0709222342190.28395@racer.site>
	<219e947f0709240350j6e011564j31a84015910ab481@mail.gmail.com>
	<Pine.LNX.4.64.0709241218280.28395@racer.site>
	<219e947f0709240712q3b8ccdaej491f777fbdc76bce@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ivan Kalvachev <ikalvachev@gmail.com>
Cc: qemu-devel@nongnu.org

Hi,

On Mon, 24 Sep 2007, Ivan Kalvachev wrote:

> 2007/9/24, Johannes Schindelin <Johannes.Schindelin@gmx.de>:
>
> > On Mon, 24 Sep 2007, Ivan Kalvachev wrote:
> >
> > > I had a discussion with Johannes Schindelin over my patch, that I 
> > > thought is on the maillist, but apparently it wasn't. I'm 
> > > subscribed, so please don't send me mails directly, gmail web 
> > > interface could be quite misleading.
> > >
> > > So here is the third revision of my patch. Changes include: using 
> > > more structures instead of fixed byte locations. chs and nt_id. more 
> > > detailed comments, function name shortened and if(lba) moved to ?: 
> > > construct.
> >
> > Almost all my comments went unheeded.
> 
> I believe that I've answered and addressed all your comments.

Ooops.  I think I mixed up your patch with the other patch for vvfat that 
floated around recently.  (Probably because the patch was not inlined...)

FWIW if we're talking about qemu_vvfat_mbr_v3.patch, I have no more 
gripes.

Thanks,
Dscho