Re: [Qemu-devel] Re: [PATCH 1/5] Fix i386 Host

[Michael Matz <matz@suse.de>]

Hi,

On Fri, 18 Jan 2008, Johannes Schindelin wrote:

> > > But apparently it has!  With gcc < 4 I did never get the error.
> > 
> > As I tried to explain, this is pure luck.
> 
> Maybe.
> 
> > > Which probably means that gcc < 4 did _not_ use ecx, and therefore it 
> > > does not have to be pushed and popped.
> > 
> > We are talking about the hunk using the "q" constraint for operand 1 in 
> > st[bw]_kernel.  The change in the clobber list (and the associated 
> > saving/restoring of %ecx around the call) is something entirely different.
> 
> It cannot be, because just changing the clobber list makes the code 
> compile again!

But I'm not talking about the clobber list at all.  I reacted to the first 
mail forwarded to me, which was a question specifically about the hunk 
adding the "q" constraint, whose purpose I explained.  Are you now also 
asking about the changes regarding %ecx and the clobber list?


Ciao,
Michael.