From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JFsIm-0007ng-1T
	for qemu-devel@nongnu.org; Fri, 18 Jan 2008 09:34:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JFsIj-0007n6-V6
	for qemu-devel@nongnu.org; Fri, 18 Jan 2008 09:34:34 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JFsIj-0007mb-Hf
	for qemu-devel@nongnu.org; Fri, 18 Jan 2008 09:34:33 -0500
Received: from cantor2.suse.de ([195.135.220.15] helo=mx2.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <matz@suse.de>) id 1JFsIj-0002BD-EZ
	for qemu-devel@nongnu.org; Fri, 18 Jan 2008 09:34:33 -0500
Date: Fri, 18 Jan 2008 15:34:30 +0100 (CET)
From: Michael Matz <matz@suse.de>
Subject: Re: [Qemu-devel] Re: [PATCH 1/5] Fix i386 Host
In-Reply-To: <alpine.LSU.1.00.0801181420100.5731@racer.site>
Message-ID: <Pine.LNX.4.64.0801181527510.20583@wotan.suse.de>
References: <alpine.LSU.1.00.0801180203440.5731@racer.site>
	<86022C39-B85C-4769-8ECD-4CB007D82F2E@suse.de>
	<Pine.LNX.4.64.0801181310220.20583@wotan.suse.de>
	<alpine.LSU.1.00.0801181243130.5731@racer.site>
	<Pine.LNX.4.64.0801181352380.20583@wotan.suse.de>
	<alpine.LSU.1.00.0801181333480.5731@racer.site>
	<Pine.LNX.4.64.0801181444130.20583@wotan.suse.de>
	<alpine.LSU.1.00.0801181420100.5731@racer.site>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: consul@collegeclub.com, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

Hi,

On Fri, 18 Jan 2008, Johannes Schindelin wrote:

> > > But apparently it has!  With gcc < 4 I did never get the error.
> > 
> > As I tried to explain, this is pure luck.
> 
> Maybe.
> 
> > > Which probably means that gcc < 4 did _not_ use ecx, and therefore it 
> > > does not have to be pushed and popped.
> > 
> > We are talking about the hunk using the "q" constraint for operand 1 in 
> > st[bw]_kernel.  The change in the clobber list (and the associated 
> > saving/restoring of %ecx around the call) is something entirely different.
> 
> It cannot be, because just changing the clobber list makes the code 
> compile again!

But I'm not talking about the clobber list at all.  I reacted to the first 
mail forwarded to me, which was a question specifically about the hunk 
adding the "q" constraint, whose purpose I explained.  Are you now also 
asking about the changes regarding %ecx and the clobber list?


Ciao,
Michael.