From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix an infinite loop in the emulated SB16 device
Date: Tue, 29 Jan 2008 19:54:09 +0300 (MSK) [thread overview]
Message-ID: <Pine.LNX.4.64.0801291945400.2124@linmac.oyster.ru> (raw)
In-Reply-To: <20080128193009.GA19255@volta.aurel32.net>
On Mon, 28 Jan 2008, Aurelien Jarno wrote:
> This patch from Tavis Ormandy <taviso@google.com> fixes an infinite
> loop in the emulated SB16 device.
>
> See http://taviso.decsystem.org/virtsec.pdf for more details.
> ---
> hw/sb16.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sb16.c b/hw/sb16.c
> index c22de7a..b2a3a70 100644
> --- a/hw/sb16.c
> +++ b/hw/sb16.c
> @@ -1246,8 +1246,10 @@ static int SB_read_DMA (void *opaque, int nchan, int dma_pos, int dma_len)
> s->block_size);
> #endif
>
> - while (s->left_till_irq <= 0) {
> - s->left_till_irq = s->block_size + s->left_till_irq;
> + if (s->block_size) {
> + while (s->left_till_irq <= 0) {
> + s->left_till_irq = s->block_size + s->left_till_irq;
> + }
> }
>
> return dma_pos;
This was fixed by commit 'Mon Jan 14 04:24:29 2008 UTC (2 weeks, 1 day
ago) by balrog', and the fix is elaborated on in:
http://lists.gnu.org/archive/html/qemu-devel/2007-05/msg00038.html
http://lists.gnu.org/archive/html/qemu-devel/2007-05/msg00019.html
--
mailto:av1474@comtv.ru
prev parent reply other threads:[~2008-01-29 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 19:30 [Qemu-devel] [PATCH] Fix an infinite loop in the emulated SB16 device Aurelien Jarno
2008-01-29 16:54 ` malc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0801291945400.2124@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).