From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JPDGX-0006FK-Jt
	for qemu-devel@nongnu.org; Wed, 13 Feb 2008 03:46:53 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JPDGW-0006Do-Lw
	for qemu-devel@nongnu.org; Wed, 13 Feb 2008 03:46:53 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JPDGW-0006De-Hj
	for qemu-devel@nongnu.org; Wed, 13 Feb 2008 03:46:52 -0500
Received: from mail.sysgo.com ([62.8.134.5])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mgroeger@sysgo.com>) id 1JPDGW-0006CJ-Rd
	for qemu-devel@nongnu.org; Wed, 13 Feb 2008 03:46:53 -0500
Date: Wed, 13 Feb 2008 09:46:44 +0100 (CET)
From: Marius Groeger <mgroeger@sysgo.com>
Sender: mag@sysgo.com
Subject: Re: [PATCH][Qemu-devel] Single stepping for PPC broken!
In-Reply-To: <200802111722.50517.rob@landley.net>
Message-ID: <Pine.LNX.4.64.0802130939190.6152@localhost>
References: <Pine.LNX.4.64.0801090849090.6836@localhost>
	<Pine.LNX.4.64.0801091312170.24129@localhost>
	<Pine.LNX.4.64.0801101454460.20346@localhost>
	<200802111722.50517.rob@landley.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rob Landley <rob@landley.net>
Cc: qemu-devel@nongnu.org

On Mon, 11 Feb 2008, Rob Landley wrote:

> On Thursday 10 January 2008 07:57:50 Marius Groeger wrote:
> > The attached patch fixes the problem, but I have to admit I can't tell
> > for sure if this doesn't break other things (such as qemu's built-in
> > GDB server). Could some QEMU ppc expert please comment on this?
> 
> Looks fine to me, but I don't see it in the git mirror I follow...
> 
> Did anybody notice this patch?

Apparently not :-)

I just checked if it still applies, and it doesn't. Checking why I ran 
into the following strangeness in target-ppc/translate.c:gen_goto_tb() 
which appeared during the TCG migration:

  ..
  if ((tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK) &&
     !ctx->singlestep_enabled) {
  ..
  } else {
    gen_set_T1(dest);
#if defined(TARGET_PPC64)
    if (ctx->sf_mode)
      gen_op_b_T1_64();
     else
#endif
      gen_op_b_T1();
    if (ctx->singlestep_enabled)
      gen_op_debug()
  }

It seems to me that the second if (ctx->singlestep_enabled) is 
rendundant.

I'll see if I can find some time to see if the patch is still needed 
and if so, update it to the current HEAD.

Thanks
Marius

-- 
Marius Groeger
SYSGO AG                      Embedded and Real-Time Software
Voice: +49 6136 9948 0                  FAX: +49 6136 9948 10
www.sysgo.com | www.elinos.com | www.osek.de | www.pikeos.com