From: malc <av1474@comtv.ru>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] alsaaudio: increase default buffer sizes
Date: Fri, 2 May 2008 23:48:42 +0400 (MSD) [thread overview]
Message-ID: <Pine.LNX.4.64.0805022335240.2121@linmac.oyster.ru> (raw)
In-Reply-To: <481B6626.7010603@web.de>
On Fri, 2 May 2008, Jan Kiszka wrote:
> Sound though the ALSA driver is skipping here unless I increase the
> buffer size. OSS seems to use 16K as well, and 1K was obviously to small
> for recording anyway.
>
> [ PS: Can someone explain to me why I also have to override the
> DAC/ADC_FIXED_FREQ to 48000 to make ALSA work? Suboptimal... ]
How exactly it doesn't work if you don't override it? Do you get any
messages prefixed with "alsa:"? As for the defaults they were set to
1024/256 because that's what was needed to make it sound on par with OSS
on the two machines i had at the time.
By the by: OSSs fragment size is specified in bytes, ALSAs on the other
hand in frames. So 16*1024 in the patch bellow means(considering
S16/stereo) 65536 bytes large buffer and 1024 bytes large period. For
OSS it's 16K bytes buffer and 4096 bytes period.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
> audio/alsaaudio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: b/audio/alsaaudio.c
> ===================================================================
> --- a/audio/alsaaudio.c
> +++ b/audio/alsaaudio.c
> @@ -58,7 +58,7 @@ static struct {
> int period_size_out_overridden;
> int verbose;
> } conf = {
> -#define DEFAULT_BUFFER_SIZE 1024
> +#define DEFAULT_BUFFER_SIZE 16*1024
> #define DEFAULT_PERIOD_SIZE 256
> #ifdef HIGH_LATENCY
> .size_in_usec_in = 1,
> @@ -72,8 +72,8 @@ static struct {
> .buffer_size_out = 400000,
> .period_size_out = 400000 / 4,
> #else
> - .buffer_size_in = DEFAULT_BUFFER_SIZE * 4,
> - .period_size_in = DEFAULT_PERIOD_SIZE * 4,
> + .buffer_size_in = DEFAULT_BUFFER_SIZE,
> + .period_size_in = DEFAULT_PERIOD_SIZE,
> .buffer_size_out = DEFAULT_BUFFER_SIZE,
> .period_size_out = DEFAULT_PERIOD_SIZE,
> .buffer_size_in_overridden = 0,
>
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2008-05-02 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 19:06 [Qemu-devel] [PATCH] alsaaudio: increase default buffer sizes Jan Kiszka
2008-05-02 19:48 ` malc [this message]
2008-05-02 21:00 ` [Qemu-devel] " Jan Kiszka
2008-05-03 19:43 ` malc
2008-05-04 7:34 ` Jan Kiszka
2008-05-04 17:09 ` malc
2008-05-04 17:41 ` Jan Kiszka
2008-05-04 19:35 ` Jan Kiszka
2008-05-05 18:03 ` malc
2008-05-05 18:43 ` Jan Kiszka
2008-05-06 17:37 ` malc
2008-05-06 17:59 ` Jan Kiszka
2008-05-07 18:36 ` malc
2008-05-07 22:24 ` Jan Kiszka
2008-05-08 17:44 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805022335240.2121@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).