From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jy9d8-0001NT-Nj for qemu-devel@nongnu.org; Mon, 19 May 2008 13:58:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jy9d7-0001NH-PZ for qemu-devel@nongnu.org; Mon, 19 May 2008 13:58:38 -0400 Received: from [199.232.76.173] (port=33853 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jy9d7-0001NE-LW for qemu-devel@nongnu.org; Mon, 19 May 2008 13:58:37 -0400 Received: from fe01x3-cgp.akado.ru ([77.232.31.164]:61045 helo=akado.ru) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jy9d7-0008Cz-HD for qemu-devel@nongnu.org; Mon, 19 May 2008 13:58:37 -0400 Received: from av1474.oops ([10.0.66.9] verified) by fe01-cgp.akado.ru (CommuniGate Pro SMTP 5.1.16) with ESMTPS id 11676776 for qemu-devel@nongnu.org; Mon, 19 May 2008 21:58:31 +0400 Date: Mon, 19 May 2008 21:58:40 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] Patch removing spaces In-Reply-To: <18481.20318.581788.423619@mariner.uk.xensource.com> Message-ID: References: <948556.48155.qm@web57013.mail.re3.yahoo.com> <18481.20318.581788.423619@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, 19 May 2008, Ian Jackson wrote: > Balazs Attila-Mihaly \(Cd-MaN\) writes ("[Qemu-devel] Patch removing >> spaces"): If anyone is interested: a patch which removes spaces from >> the end of the lines. Compressed because it's rather big. > > Please don't apply this patch! > > Spaces at the ends of lines are indeed irritating and we should avoid > them. But going out of our way to remove them is definitely wrong - > it's reformatting, which is nearly always wrong in Free Software. > [..snip..] Preventive measure that makes the code look sufficiently ugly when tabs or trailing whitespace is present. Hands almost reflectively reach for `M-x nuke-trailing-whitespace' and `C-x h M-x untabify' (defface font-lock-ws-face '((((class color) (background dark)) (:background "white")) (((class color) (background light)) (:background "black")) (t (:bold t))) "Font Lock mode face used to highlight unwated whitespace." :group 'font-lock-faces) (setq font-lock-ws-face 'font-lock-ws-face) (defun font-lock-mode-hook-fn () (setq old-font-lock-keywords font-lock-keywords) (make-variable-buffer-local 'font-lock-keywords) (let ((elem (list (list "\\([ \t]+$\\)\\|\\(\t\\)" (list 0 font-lock-ws-face))))) (setq font-lock-keywords (append font-lock-keywords elem)))) (add-hook 'font-lock-mode-hook 'font-lock-mode-hook-fn) -- mailto:av1474@comtv.ru