From: malc <av1474@comtv.ru>
To: Fabrice Bellard <fabrice@bellard.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4705] Fix div[u]2.
Date: Tue, 10 Jun 2008 03:47:03 +0400 (MSD) [thread overview]
Message-ID: <Pine.LNX.4.64.0806100345270.23608@linmac.oyster.ru> (raw)
In-Reply-To: <484D90AD.2020500@bellard.org>
On Mon, 9 Jun 2008, Fabrice Bellard wrote:
> malc wrote:
>> On Mon, 9 Jun 2008, Fabrice Bellard wrote:
>>
>>> malc wrote:
>>>> Revision: 4705
>>>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4705
>>>> Author: malc
>>>> Date: 2008-06-09 06:06:25 +0000 (Mon, 09 Jun 2008)
>>>>
>>>> Log Message:
>>>> -----------
>>>> Fix div[u]2.
>>>>
>>>> Previous code assummed 32 by 32 bit divmod operation, and survived
>>>> x86_64 test only by sheer luck. MIPS wasn't so forgiving.
>>>
>>> Are you sure it is needed ? div[u]2 support in currently optional in
>>> TCG. On some hosts such as PowerPC, implementing div[u] directly is
>>> simpler. rem[u] can be implemented generically then.
>>
>> When i added TCG_TARGET_HAS_div_i32 plus all that is necessary to handle
>> div[u]/rem[u]_i32 tcg started to abort at tcg.c:1180 (at least for
>> arm-softmmu)
>
> So this is the bug to solve. Adding divu2 is not necessary, at least
> until we decided it is necessary for all TCG targets.
Sorry i messed up with dependencies, everything is working with
TCG_TARGET_HAS_div_i32. It's worth noting that PPC is the only TCG
target that uses it though.
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2008-06-09 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 6:06 [Qemu-devel] [4705] Fix div[u]2 malc
2008-06-09 8:34 ` Fabrice Bellard
2008-06-09 20:02 ` malc
2008-06-09 20:21 ` Fabrice Bellard
2008-06-09 23:47 ` malc [this message]
2008-06-09 16:44 ` C.W. Betts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806100345270.23608@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).