From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K6VWR-0000cv-DB
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 14:58:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K6VWQ-0000c4-PV
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 14:58:15 -0400
Received: from [199.232.76.173] (port=40178 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K6VWQ-0000c1-LG
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 14:58:14 -0400
Received: from nuitari.net ([67.205.71.108]:45619 helo=anvil.nuitari.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nuitari-qemu@nuitari.net>) id 1K6VWQ-00030O-Jm
	for qemu-devel@nongnu.org; Wed, 11 Jun 2008 14:58:14 -0400
Date: Wed, 11 Jun 2008 15:02:27 -0400 (EDT)
From: nuitari-qemu@nuitari.net
Subject: Re: [Qemu-devel] Re: Problem(s) with encrypted images
In-Reply-To: <01f001c8cb07$28c41d90$0201a8c0@zeug>
Message-ID: <Pine.LNX.4.64.0806111439480.18515@anvil.nuitari.net>
References: <Pine.LNX.4.64.0806092312040.18515@anvil.nuitari.net>
	<019c01c8cafe$d64f6310$0201a8c0@zeug>
	<01f001c8cb07$28c41d90$0201a8c0@zeug>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

>> >  2. When I start qemu, it just hangs there waiting for (assumingly) the 
>> >  password of the encrypted image. However I cannot find the place where 
>> >  the prompt actually is.
>>
>>  qemu_key_check in vl.c does use monitor_readline, so you should see a
>>  "Password:"
>>  prompt in the monitor window (press ctrl-alt-2 to get there).
>
> The initialization order seems to be wrong in main() (vl.c):
>
>    for(i = 0; i < nb_drives_opt; i++)
>        if (drive_init(&drives_opt[i], snapshot, machine) == -1)
>            exit(1);
>    ...
>    *_display_init();
>    ...
>    monitor_init();
>
> drive_init() got
> ...
> if (bdrv_open2(bdrv, file, bdrv_flags, drv) < 0 || qemu_key_check(bdrv, 
> file)) {
>
> and qemu_key_check depends on the monitor:
>
>    term_printf("%s is encrypted.\n", name);
>    for(i = 0; i < 3; i++) {
>        monitor_readline("Password: ", 1, password, sizeof(password));

Just changing the order in vl.c doesn't work.

For example I get:
VM_Serveur_de_scripts.crypt.qcow2 is encrypted.
Password: QEMU 0.9.1 monitor - type 'help' for more information
(qemu) blahblahblahblah
unknown command: 'blahblahblahblah'
(qemu)
(qemu)

Also connecting to vnc results in a segmentation fault with the reordering 
that I did.