From: malc <av1474@comtv.ru>
To: Qemu list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Fix warnings : hw/fmopl.[ch] (BUILD_Y8950 is not defined)
Date: Tue, 11 Nov 2008 00:08:07 +0300 (MSK) [thread overview]
Message-ID: <Pine.LNX.4.64.0811110004470.2924@linmac.oyster.ru> (raw)
In-Reply-To: <292017.13943.qm@web24506.mail.ird.yahoo.com>
On Mon, 10 Nov 2008, Sylvain Petreolle wrote:
> Signed-off by: Sylvain Petreolle<spetreolle@yahoo.fr>
> Index: hw/fmopl.c
> ===================================================================
> --- hw/fmopl.c (r?vision 5668)
> +++ hw/fmopl.c (copie de travail)
> @@ -813,7 +813,7 @@
> }
> }
> return;
> -#if BUILD_Y8950
> +#ifdef BUILD_Y8950
[..snip..]
>
First of all fmopl.c is foreign code so touching it without clear need
would be a mistake, secondly, the same effect can be achieved by
#define BUILD_[Y8950|whatever] 0
in fmopl.h making for a much slimmer patch.
--
mailto:av1474@comtv.ru
prev parent reply other threads:[~2008-11-10 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 14:21 [Qemu-devel] [PATCH] Fix warnings : hw/fmopl.[ch] (BUILD_Y8950 is not defined) Sylvain Petreolle
2008-11-10 21:08 ` malc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811110004470.2924@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).