From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [6009] Fix smsw for x86_64 guest and bigendian host case
Date: Sat, 13 Dec 2008 23:16:37 +0300 (MSK) [thread overview]
Message-ID: <Pine.LNX.4.64.0812132315020.2164@linmac.oyster.ru> (raw)
In-Reply-To: <20081213161337.GA11499@miranda.arrow>
On Sat, 13 Dec 2008, Stuart Brady wrote:
> On Sat, Dec 13, 2008 at 03:51:14PM +0000, malc wrote:
>> +#if defined TARGET_X86_64 && defined WORDS_BIGENDIAN
>> + tcg_gen_ld32u_tl(cpu_T[0], cpu_env, offsetof(CPUX86State,cr[0]) + 4);
>> +#else
>> tcg_gen_ld32u_tl(cpu_T[0], cpu_env, offsetof(CPUX86State,cr[0]));
>> +#endif
>
> Hmm -- shouldn't REG_L_OFFSET be added instead of using #ifdefs?
Probably not. This mixes GPRs with CRs, that said the core idea is sound.
--
mailto:av1474@comtv.ru
prev parent reply other threads:[~2008-12-13 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 15:51 [Qemu-devel] [6009] Fix smsw for x86_64 guest and bigendian host case malc
2008-12-13 16:13 ` Stuart Brady
2008-12-13 20:16 ` malc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0812132315020.2164@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).