From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Building QEMU CVS with DirectSound on MinGW broken
Date: Mon, 2 Feb 2009 01:04:15 +0300 (MSK) [thread overview]
Message-ID: <Pine.LNX.4.64.0902020056180.2801@linmac.oyster.ru> (raw)
In-Reply-To: <498610D2.5050603@bttr-software.de>
On Sun, 1 Feb 2009, Robert Riebisch wrote:
> Hi!
>
> I'm getting this error:
> c:/MinGW/bin/../lib/gcc/mingw32/3.4.5/../../../../include/rpcdce.h:369:
> error: syntax error before "__attribute__"
>
> I was able to fix this by moving inclusion of `dsound.h' above that of
> `qemu-common.h'. The real cause seems to be "#define noreturn
> __attribute__ ((__noreturn__))" in `qemu-common.h'. This has been added
> in r6303 and "fixed" in r6330.
Aha, so finally we are at the bottom of things. Thanks.
[..snip..]
>
> I've just removed `objbase.h', because it will be included with
> `dsound.h' already.
The fix however is wrong, Microsoft states that CoCreateInstance
should reside in objbase.h thus removing it is wrong, unless somone
could find the same being stated about dsound.h always including objbase.
While pretty and seductive the idea of lower case noreturn was always
rotten. (Not that one can not make a strong case for blaming w32api
developers for that particular way of handling noreturn in rpcdce.h)
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2009-02-01 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 21:14 [Qemu-devel] Building QEMU CVS with DirectSound on MinGW broken Robert Riebisch
2009-02-01 22:04 ` malc [this message]
[not found] ` <1D432B39-17C0-4F1C-971B-255F015A10AE@hotmail.com>
2009-02-01 22:29 ` C.W. Betts
2009-02-01 22:38 ` Robert Riebisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0902020056180.2801@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).