From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
markmc@redhat.com, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti
Date: Wed, 4 Feb 2009 03:18:10 +0300 (MSK) [thread overview]
Message-ID: <Pine.LNX.4.64.0902040317090.3400@linmac.oyster.ru> (raw)
In-Reply-To: <4988AECB.2070208@codemonkey.ws>
On Tue, 3 Feb 2009, Anthony Liguori wrote:
> Blue Swirl wrote:
> > On 2/3/09, Alex Williamson <alex.williamson@hp.com> wrote:
> >
> > > Make use of the new RX_MODE control virtqueue class by dropping
> > > packets the guest doesn't want to see.
> > >
> > > Signed-off-by: Alex Williamson <alex.williamson@hp.com>
> > >
> >
> >
> > > + static uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
> > >
> >
> > 'const'?
> >
>
> It may be good practice but practically speaking, I don't think it will
> generate different code. The only thing that uses bcast is memcmp() which
> should be a builtin. Since bcast doesn't otherwise escape the function, it's
> an obvious candidate for optimization. I think the compiler already has
> enough information that const doesn't tell it anything more.
It does generate different code, bcast is being put into rodata in case
of const and data otherwise, whether it makes practical difference for
QEMU is another matter.
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2009-02-04 0:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 19:29 [Qemu-devel] [PATCH v2 0/8] qemu:virtio-net: Add MAC and VLAN filtering Alex Williamson
2009-02-03 19:29 ` [Qemu-devel] [PATCH v2 1/8] qemu:virtio-net: Save status and add some save infrastructure Alex Williamson
2009-02-03 19:29 ` [Qemu-devel] [PATCH v2 2/8] qemu:virtio-net: Allow setting the MAC address via set_config Alex Williamson
2009-02-03 19:29 ` [Qemu-devel] [PATCH v2 3/8] qemu:virtio-net: Define ETH_ALEN for use when manipulating MAC addresses Alex Williamson
2009-02-03 19:29 ` [Qemu-devel] [PATCH v2 4/8] qemu:virtio-net: Add a virtqueue for control commands from the guest Alex Williamson
2009-02-03 20:56 ` [Qemu-devel] " Anthony Liguori
2009-02-04 22:59 ` Alex Williamson
2009-02-04 23:09 ` malc
2009-02-04 23:34 ` Alex Williamson
2009-02-04 23:14 ` Anthony Liguori
2009-02-03 19:29 ` [Qemu-devel] [PATCH v2 5/8] qemu:virtio-net: Add promiscuous and all-multicast mode bits Alex Williamson
2009-02-03 19:30 ` [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti Alex Williamson
2009-02-03 20:06 ` Blue Swirl
2009-02-03 20:53 ` Anthony Liguori
2009-02-03 23:35 ` Paul Brook
2009-02-04 0:18 ` malc [this message]
2009-02-03 19:30 ` [Qemu-devel] [PATCH v2 7/8] qemu:virtio-net: Add additional MACs via a filter table Alex Williamson
2009-02-03 19:30 ` [Qemu-devel] [PATCH v2 8/8] qemu:virtio-net: Add VLAN filtering Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0902040317090.3400@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).