Re: [Qemu-devel] [PATCH][RFC] Fix SDL on evdev hosts

[malc <av1474@comtv.ru>]

On Fri, 27 Feb 2009, Blue Swirl wrote:

> On 2/27/09, Anthony Liguori <aliguori@us.ibm.com> wrote:
> > This patch corrects SDL support on X11 hosts using evdev.  It's losely based
> >  on the previous patch by Dustin Kirkland and the evdev support code in gtk-vnc
> >  written by Daniel Berrange.
> >
> >  I've tried to take into account all past feedback from previous patches posted
> >  including a proper set of configure checks.  I've tested this on win32 but
> >  I'd like some more eyes to look at it.
> >
> >  Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> 
> Just a micro nitpick:
> >  +#ifndef _QEMU_X_KEYMAP_H
> >  +#define _QEMU_X_KEYMAP_H

And it should be QEMU_X_KEYMAP_H.

> >  +
> >  +extern uint8_t translate_xfree86_keycode(const int key);
> >  +
> >  +extern uint8_t translate_evdev_keycode(const int key);
> >  +
> >  +#endif
> >  +
> 
> Looks like an extra newline at the end of file? ;-)
> 
> The #endif does not have the traditional /* _QEMU_X_KEYMAP_H */
> ending, but I don't care much for those.
> 
> 

-- 
mailto:av1474@comtv.ru