From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC][PATCH] Fix race condition on access to env->interrupt_request
Date: Fri, 6 Mar 2009 22:06:38 +0300 (MSK) [thread overview]
Message-ID: <Pine.LNX.4.64.0903062205220.3044@linmac.oyster.ru> (raw)
In-Reply-To: <20090306173143.GA13368@volta.aurel32.net>
On Fri, 6 Mar 2009, Aurelien Jarno wrote:
> env->interrupt_request is accessed as the bit level from both main code
> and signal handler, making a race condition possible even on CISC CPU.
> This causes freeze of QEMU under high load when running the dyntick
> clock.
>
> The patch below move the bit corresponding to CPU_INTERRUPT_EXIT in a
> separate variable, declared as volatile sig_atomic_t, so it should be
> work even on RISC CPU.
>
> We may want to move the cpu_interrupt(env, CPU_INTERRUPT_EXIT) case in
> its own function and get rid of CPU_INTERRUPT_EXIT. That can be done
> later, I wanted to keep the patch short for easier review.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
Looks good.
--
mailto:av1474@comtv.ru
prev parent reply other threads:[~2009-03-06 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 17:31 [Qemu-devel] [RFC][PATCH] Fix race condition on access to env->interrupt_request Aurelien Jarno
2009-03-06 19:06 ` malc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0903062205220.3044@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).