qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Document QEMU coding style (v2)
Date: Wed, 1 Apr 2009 19:35:06 +0400 (MSD)	[thread overview]
Message-ID: <Pine.LNX.4.64.0904011934410.2160@linmac.oyster.ru> (raw)
In-Reply-To: <20090401133828.GC24403@edgar.se.axis.com>

On Wed, 1 Apr 2009, Edgar E. Iglesias wrote:

> On Tue, Mar 31, 2009 at 08:23:06PM +0300, Avi Kivity wrote:
> > With the help of some Limoncino I noted several aspects of the QEMU coding
> > style, particularly where it differs from the Linux coding style as many
> > contributors work on both projects.
> > 
> > Signed-off-by: Avi Kivity <avi@redhat.com>
> > 
> > Changes from v1:
> >   - s/Qemu/QEMU/
> >   - s/Posix/POSIX/
> >   - note that the _t suffix is not POSIX compliant, and will be changed
> >   - discourage eol whitespace
> >   - be strict about the 80 char line width
> > ---
> >  CODING_STYLE |   78 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 78 insertions(+), 0 deletions(-)
> >  create mode 100644 CODING_STYLE
> > 
> > diff --git a/CODING_STYLE b/CODING_STYLE
> > new file mode 100644
> > index 0000000..1ab13b6
> > --- /dev/null
> > +++ b/CODING_STYLE
> > @@ -0,0 +1,78 @@
> > +Qemu Coding Style
> > +=================
> > +
> > +1. Whitespace
> > +
> > +Of course, the most important aspect in any coding style is whitespace.
> > +Crusty old coders who have trouble spotting the glasses on their noses
> > +can tell the difference between a tab and eight spaces from a distance
> > +of approximately fifteen parsecs.  Many a flamewar have been fought and
> > +lost on this issue.
> > +
> > +QEMU indents are four spaces.  Tabs are never used, except in Makefiles
> > +where they have been irreversibly coded into the syntax by some moron.
> > +Spaces of course are superior to tabs because:
> 
> 
> Hi I'd appreciate it if we removed the insults and the arrogance, i.e
> skip the "moron" and the of courses. Other than that most of this stuff

Seconded.

> looks acceptable to me, although I don't necessarily agree with all of
> it :)

[..snip..]

-- 
mailto:av1474@comtv.ru

  parent reply	other threads:[~2009-04-01 15:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 17:23 [Qemu-devel] [PATCH] Document QEMU coding style (v2) Avi Kivity
2009-04-01 13:38 ` Edgar E. Iglesias
2009-04-01 14:13   ` Laurent Vivier
2009-04-01 14:25     ` John Haxby
2009-04-01 15:47       ` Avi Kivity
2009-04-01 15:35   ` malc [this message]
2009-04-05 17:40 ` [Qemu-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0904011934410.2160@linmac.oyster.ru \
    --to=av1474@comtv.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).