qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: malc <av1474@comtv.ru>
To: Brad <brad@comstyle.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC
Date: Sun, 10 May 2009 22:41:13 +0400 (MSD)	[thread overview]
Message-ID: <Pine.LNX.4.64.0905102240440.2175@linmac.oyster.ru> (raw)
In-Reply-To: <20090510021217.GA26523@booyah.home.comstyle.com>

On Sat, 9 May 2009, Brad wrote:

> On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
> > On Fri, 10 Apr 2009, Brad wrote:
> > 
> > > Trying to build on an OpenBSD PowerPC machine dies pretty quickly
> > > in the TCG PowerPC code..
> > > 
> > >    CC    i386-softmmu/exec.o
> > >  In file included from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/tcg.h:24,
> > >                   from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/exec.c:39:
> > >  /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/ppc/tcg-target.h:76:2: #error 
> > > Unsupported system
> > >  gmake[1]: *** [exec.o] Error 1
> > > 
> > > Any help with this?
> > 
> > You need to know which ABI OpenBSD/PPC uses. A shot in the dark would be
> > to try something like:
> 
> After speaking to the PowerPC maintainer to double check, we're
> using the standard SVR4 ABI so this should be good..
> 
> Also as far as I know this should also apply to FreeBSD and NetBSD
> when running on PowerPC, but I'll leave it at this for now.

Good.
 
> 
> --- tcg/ppc/tcg-target.c.orig	Fri May  8 02:39:52 2009
> +++ tcg/ppc/tcg-target.c	Fri May  8 02:41:24 2009
> @@ -109,7 +109,7 @@ static const int tcg_target_reg_alloc_order[] = {
>      TCG_REG_R11,
>  #endif
>      TCG_REG_R12,
> -#ifndef __linux__
> +#if !defined(__linux__) && !defined(__OpenBSD__)
>      TCG_REG_R13,
>  #endif
>      TCG_REG_R0,
> @@ -1535,7 +1535,7 @@ void tcg_target_init(TCGContext *s)
>  #ifndef __APPLE__
>      tcg_regset_set_reg(s->reserved_regs, TCG_REG_R2);
>  #endif
> -#ifdef __linux__
> +#if defined(__linux__) || defined(__OpenBSD__)
>      tcg_regset_set_reg(s->reserved_regs, TCG_REG_R13);
>  #endif
>  
> --- tcg/ppc/tcg-target.h.orig	Mon Apr  6 22:04:47 2009
> +++ tcg/ppc/tcg-target.h	Sun Apr 26 20:15:41 2009
> @@ -69,7 +69,7 @@ enum {
>  #define TCG_TARGET_CALL_STACK_OFFSET 24
>  #elif defined _AIX
>  #define TCG_TARGET_CALL_STACK_OFFSET 52
> -#elif defined __linux__
> +#elif defined __linux__ || defined __OpenBSD__
>  #define TCG_TARGET_CALL_ALIGN_ARGS 1
>  #define TCG_TARGET_CALL_STACK_OFFSET 8
>  #else

You tested this and it works?

-- 
mailto:av1474@comtv.ru

  reply	other threads:[~2009-05-10 18:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-10 12:21 [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC Brad
2009-04-10 12:39 ` Andreas Färber
2009-04-11  6:58 ` malc
2009-05-10  2:12   ` Brad
2009-05-10 18:41     ` malc [this message]
2009-05-10 19:00       ` Brad
2009-05-10 21:27         ` malc
2009-05-11 15:30           ` Blue Swirl
2009-05-11 16:59             ` Brad
2009-05-11 18:00               ` Andreas Färber
2009-05-11 18:20               ` Blue Swirl
2009-05-11  1:46       ` M. Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0905102240440.2175@linmac.oyster.ru \
    --to=av1474@comtv.ru \
    --cc=brad@comstyle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).