Re: [Qemu-devel] [PATCH] build fix: xen on NetBSD/amd64

[malc <av1474@comtv.ru>]

On Fri, 10 Jul 2009, Christoph Egger wrote:

> On Friday 10 July 2009 14:58:48 Anthony Liguori wrote:
> > Christoph Egger wrote:
> > > On Thursday 09 July 2009 21:21:06 Anthony Liguori wrote:
> > >> Christoph Egger wrote:
> > >>> Hi!
> > >>>
> > >>> Attached patch fixes this build error on NetBSD/amd64:
> > >>>
> > >>> hw/xen_blkif.h:20: warning: #pragma pack(psuh[, id], <n>) is not
> > >>> supported on this target
> > >>> hw/xen_blkif.h:36: warning: #pragma pack(pop[, id], <n>) is not
> > >>> supported on this target
> > >>>
> > >>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> > >>
> > >> You'll invoke the fury of malc for introducing an identifier that begins
> > >> with '__' :-)
> > >
> > > In NetBSD, there is this in <sys/cdefs.h> :
> >
> > NetBSD is allowed to use these names in system headers but according to
> > the C standard, normal programs like QEMU aren't.  So we need to use
> > something other than __aligned.
>
> What about  __qemu_aligned ?
>
> #ifdef __NetBSD__
> #define __qemu_aligned(x)    __aligned(x)
> #else
> #define __qemu_aligned(x)    __attribute__((__aligned__(x)))
> #endif

Let me quote the standard once again:

       7.1.3  Reserved identifiers
[..snip..]
         -- All  identifiers  that  begin  with  an  underscore and
            either an uppercase letter or  another  underscore  are
            always reserved for any use.

-- 
mailto:av1474@comtv.ru