From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPHxV-0004Bw-LA
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 11:24:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPHxV-0004Bk-D3
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 11:24:21 -0400
Received: from [199.232.76.173] (port=52339 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPHxV-0004Bg-2c
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 11:24:21 -0400
Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:57562 helo=akado.ru)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <av1474@comtv.ru>) id 1MPHxU-00089O-LG
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 11:24:20 -0400
Date: Fri, 10 Jul 2009 19:24:24 +0400 (MSD)
From: malc <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PATCH] build fix: xen on NetBSD/amd64
In-Reply-To: <200907101520.38417.Christoph.Egger@amd.com>
Message-ID: <Pine.LNX.4.64.0907101922200.2268@linmac.oyster.ru>
References: <200906301513.12043.Christoph.Egger@amd.com>
	<200907101019.31977.Christoph.Egger@amd.com>
	<4A573B08.9010903@codemonkey.ws>
	<200907101520.38417.Christoph.Egger@amd.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: qemu-devel@nongnu.org

On Fri, 10 Jul 2009, Christoph Egger wrote:

> On Friday 10 July 2009 14:58:48 Anthony Liguori wrote:
> > Christoph Egger wrote:
> > > On Thursday 09 July 2009 21:21:06 Anthony Liguori wrote:
> > >> Christoph Egger wrote:
> > >>> Hi!
> > >>>
> > >>> Attached patch fixes this build error on NetBSD/amd64:
> > >>>
> > >>> hw/xen_blkif.h:20: warning: #pragma pack(psuh[, id], <n>) is not
> > >>> supported on this target
> > >>> hw/xen_blkif.h:36: warning: #pragma pack(pop[, id], <n>) is not
> > >>> supported on this target
> > >>>
> > >>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> > >>
> > >> You'll invoke the fury of malc for introducing an identifier that begins
> > >> with '__' :-)
> > >
> > > In NetBSD, there is this in <sys/cdefs.h> :
> >
> > NetBSD is allowed to use these names in system headers but according to
> > the C standard, normal programs like QEMU aren't.  So we need to use
> > something other than __aligned.
>
> What about  __qemu_aligned ?
>
> #ifdef __NetBSD__
> #define __qemu_aligned(x)    __aligned(x)
> #else
> #define __qemu_aligned(x)    __attribute__((__aligned__(x)))
> #endif

Let me quote the standard once again:

       7.1.3  Reserved identifiers
[..snip..]
         -- All  identifiers  that  begin  with  an  underscore and
            either an uppercase letter or  another  underscore  are
            always reserved for any use.

-- 
mailto:av1474@comtv.ru