From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MW7mi-0006C8-Mk for qemu-devel@nongnu.org; Wed, 29 Jul 2009 07:57:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MW7mg-0006Bd-9o for qemu-devel@nongnu.org; Wed, 29 Jul 2009 07:57:27 -0400 Received: from [199.232.76.173] (port=34121 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MW7mf-0006As-CE for qemu-devel@nongnu.org; Wed, 29 Jul 2009 07:57:25 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:59878 helo=akado.ru) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MW7ma-0007zG-UE for qemu-devel@nongnu.org; Wed, 29 Jul 2009 07:57:21 -0400 Date: Wed, 29 Jul 2009 15:57:15 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [PATCH] alsa broken when the host is suspended (or hibernated) In-Reply-To: <1248864666-31387-1-git-send-email-bjorn@mork.no> Message-ID: References: <1248864666-31387-1-git-send-email-bjorn@mork.no> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="33734824-164132554-1248868635=:3728" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?q?Bj=C3=B8rn=20Mork?= Cc: qemu-devel@nongnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --33734824-164132554-1248868635=:3728 Content-Type: TEXT/PLAIN; charset=koi8-r Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 29 Jul 2009, Bjrn Mork wrote: > audio output fails after resuming a host running a guest using alsa > audio output. Messages such as >=20 > alsa: Failed to write 882 frames to 0x1804b98 > alsa: Reason: Streams pipe error >=20 > will appear repeatedly in the monitor. This is caused by alsaaudio.c > not handling ESTRPIPE. Fix this by calling snd_pcm_resume() on > ESTRPIPE. >=20 > This bug is similar to the vlc bug discussed on > https://trac.videolan.org/vlc/ticket/1286 and the fix is insired by > the patch attached to that bug report >=20 > Signed-off-by: Bj=FF=FFrn Mork > --- > audio/alsaaudio.c | 22 ++++++++++++++++++++++ > 1 files changed, 22 insertions(+), 0 deletions(-) Thank you. I've massaged the patch a bit: a. Trimmed the comment line to fit 80 columns b. Suppressed tabs c. Added -ESTRPIPE handling to alsa_run_in d. Changed the verbose message to indicate which of the streams is being resumed (input/output) It would be very nice if you could verify that it still works since my machine is not capable of suspending nor hibernating, it would be very informative if you could run audio capture inside the guest to verify c. and d. The tree is at: http://repo.or.cz/w/qemu/malc.git?a=3Dshortlog;h=3Drefs/heads/alsa Or you can just apply first commit's patch. [..snip..] P.S. Perhaps you could also come up with a better subject line? --=20 mailto:av1474@comtv.ru --33734824-164132554-1248868635=:3728--