From: malc <av1474@comtv.ru>
To: "Reimar Döffinger" <Reimar.Doeffinger@gmx.de>
Cc: qemu-devel@nongnu.org, Pierre Riteau <Pierre.Riteau@irisa.fr>
Subject: Re: [Qemu-devel] [PATCH v2] Fix compilation of check-qint.c by using a long long integer constant
Date: Fri, 4 Sep 2009 21:49:14 +0400 (MSD) [thread overview]
Message-ID: <Pine.LNX.4.64.0909042149080.2268@linmac.oyster.ru> (raw)
In-Reply-To: <20090904172935.GA4163@1und1.de>
On Fri, 4 Sep 2009, Reimar D?ffinger wrote:
> On Fri, Sep 04, 2009 at 07:09:58PM +0200, Pierre Riteau wrote:
> > Error was:
> > check-qint.c:46: error: integer constant is too large for 'long' type
> > ---
> > check-qint.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/check-qint.c b/check-qint.c
> > index ae5d22f..f5c054e 100644
> > --- a/check-qint.c
> > +++ b/check-qint.c
> > @@ -43,7 +43,7 @@ END_TEST
> > START_TEST(qint_from_int64_test)
> > {
> > QInt *qi;
> > - const int64_t value = 0xffffffffffffffff;
> > + const int64_t value = 0xffffffffffffffffLL;
>
> Hm, well it does not really fit in a signed long long either (so from that
> aspect it should be ULL).
> Should it not be simply -1 (does qemu assume all architectures
> use two's complement?)?
Yes.
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2009-09-04 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 17:09 [Qemu-devel] [PATCH v2] Fix compilation of check-qint.c by using a long long integer constant Pierre Riteau
2009-09-04 17:29 ` Reimar Döffinger
2009-09-04 17:49 ` malc [this message]
2009-09-05 1:58 ` Jamie Lokier
2009-09-04 17:56 ` Pierre Riteau
2009-09-04 18:25 ` Luiz Capitulino
2009-09-05 8:07 ` Reimar Döffinger
2009-09-08 9:54 ` Pierre Riteau
2009-09-04 17:38 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0909042149080.2268@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=Pierre.Riteau@irisa.fr \
--cc=Reimar.Doeffinger@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).