Re: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state

[malc <av1474@comtv.ru>]

On Wed, 30 Sep 2009, Anthony Liguori wrote:

> malc wrote:
> > On Wed, 30 Sep 2009, Anthony Liguori wrote:
> >   
> > > So I think we should bump the version of the ac97 format, remove the
> > > active[] array from the vmstate, and then generate it in a post function
> > > that can then be passed to reset_voices().
> > >     
> > 
> > Yes, however, what bothers me though, is that i ended up NOT doing that
> > when the original code was written, there must have been a reason for me
> > not doing that, and it completely elludes me at the moment, so no this
> > isn't better yet, better yet implies someone having to go through the
> > code and figure out whether it's safe or not.
> >   
> 
> I'm pretty convinced it's safe.  The only way it wouldn't be is if it was
> possible for the active_in/active_out state in AUD to be changed through a
> means other than the device itself.  Looking at audio.c, it's not possible.
> 
> But I also expect that Juan will be testing this device model when he
> resubmits the patch so that should confirm it.

Okay then, given it is tested.

-- 
mailto:av1474@comtv.ru