From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mt8Uy-0004Os-KH
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:22:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mt8Uy-0004ON-6c
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:22:16 -0400
Received: from [199.232.76.173] (port=54416 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mt8Ux-0004OB-PY
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:22:15 -0400
Received: from mx20.gnu.org ([199.232.41.8]:61756)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <av1474@comtv.ru>) id 1Mt8Ux-00082k-Cs
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:22:15 -0400
Received: from fe02x03-cgp.akado.ru ([77.232.31.165] helo=akado.ru)
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <av1474@comtv.ru>) id 1Mt8Uw-00045L-30
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:22:14 -0400
Date: Thu, 1 Oct 2009 03:22:04 +0400 (MSD)
From: malc <av1474@comtv.ru>
Subject: Re: [Qemu-devel] Questions on audio_atexit(), possibly bugs
In-Reply-To: <871vlo9gz5.fsf@pike.pond.sub.org>
Message-ID: <Pine.LNX.4.64.0910010316150.26572@linmac.oyster.ru>
References: <87y6nw9koq.fsf@pike.pond.sub.org>
	<Pine.LNX.4.64.0910010234080.26485@linmac.oyster.ru>
	<871vlo9gz5.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, 1 Oct 2009, Markus Armbruster wrote:

> malc <av1474@comtv.ru> writes:
> 
> > On Wed, 30 Sep 2009, Markus Armbruster wrote:
> >
> >> Excuse my ignorance on all things audio, but I stumbled over something
> >> that could be wrong.
> >> 
> >> audio_vm_change_state_handler() stops voices when the VM stops, and
> >> starts them when it continues.
> >> 
> >> audio_atexit() unconditionally stops them.  When a stopped VM exits,
> >> this stops voices that are already stopped.
> >> 
> >> Does the audio driver contract allow stopping a stopped voice?  If yes,
> >> I figured starting a running voice is fine, too.  If no, we have a bug
> >> in audio_atexit().
> >
> > This should answer the question audio_atexit existed long before vm
> > change state handlers. Those were actually added to stop the host from
> > looping the same audio fragment over and over again (can/will happen
> > with DirectSound, mmapped OSS, fmod too if i'm not mistaken).
> 
> Just to make sure: Does this mean implementations of audio_pcm_ops need
> to cope with stopping a stopped voice?

Yes.

[..snip..]

-- 
mailto:av1474@comtv.ru