From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtQfe-0004cZ-FP
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 14:46:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtQfd-0004bI-4M
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 14:46:29 -0400
Received: from [199.232.76.173] (port=51642 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtQfd-0004b8-0K
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 14:46:29 -0400
Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:50305 helo=akado.ru)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <av1474@comtv.ru>) id 1MtQfc-0002Dx-Ja
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 14:46:28 -0400
Date: Thu, 1 Oct 2009 22:46:27 +0400 (MSD)
From: malc <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PATCH 4/9] pci: use uint64_t for bar addr and size
	instead of uint32_t.
In-Reply-To: <4AC4B47E.5010309@codemonkey.ws>
Message-ID: <Pine.LNX.4.64.0910012246010.2005@linmac.oyster.ru>
References: <1247656509-32227-1-git-send-email-yamahata@valinux.co.jp>
	<1247656509-32227-5-git-send-email-yamahata@valinux.co.jp>
	<20090930114122.GG18802@redhat.com>
	<Pine.LNX.4.64.0909301925180.14276@linmac.oyster.ru>
	<20090930161547.GB21595@redhat.com>
	<Pine.LNX.4.64.0909302050270.19650@linmac.oyster.ru>
	<20090930172641.GA28300@redhat.com>
	<Pine.LNX.4.64.0909302158070.20453@linmac.oyster.ru>
	<20091001053302.GA3317@redhat.com>
	<Pine.LNX.4.64.0910011613470.2148@linmac.oyster.ru>
	<4AC4B47E.5010309@codemonkey.ws>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, 1 Oct 2009, Anthony Liguori wrote:

> malc wrote:
> > I don't understand this at all. POSIX says that if you include any of
> > it's headers be prepared to deal with it, i.e. any of your own
> > typedefs that end with _t are potentially clashing with what's defined
> > there, similarly identifiers that start with 'str', 'E', double
> > underscore and underscore followed by a capital letter are reserved by
> > C, you just don't go there.
> >   
> 
> _t is used pervasively throughout the code right now.  In particular, we have
> ram_addr_t and target_phys_addr_t.  pci_addr_t is a logical addition.
> 
> I do agree that adhering to Posix is a good thing, but I think either we have
> to go through and fixup all of the _t's in the code today, or just accept the
> fact that we don't strictly adhere to Posix and deal with it if we ever have
> to.
> 
> The middle ground where we don't allow new uses of _t but keep the old ones is
> just going to result in mass confusion and bike shedding.
> 

Agreed. Let's see how removing it will not lead to bike shedding.

-- 
mailto:av1474@comtv.ru