From: malc <av1474@comtv.ru>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 1/8] musicpal: Catch null TX qeueues
Date: Sun, 4 Oct 2009 10:57:43 +0400 (MSD) [thread overview]
Message-ID: <Pine.LNX.4.64.0910041054150.2134@linmac.oyster.ru> (raw)
In-Reply-To: <20090918185122.2879.37050.stgit@mchn012c.ww002.siemens.net>
On Fri, 18 Sep 2009, Jan Kiszka wrote:
> They likely represent invalid queues that should be skipped. We already
> do this for RX queues. Wish I had a spec...
>
> Credits go to malc for analyzing the issue and suggesting this fix.
>
What bothers me is:
a. Why 930c86820e8e0b6dfcf211bda5e835463d72ff42 (disregarding dodgy
reading into structures directly) and why only on a PPC
b. Why the "fix" was not needed before
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2009-10-04 6:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 18:51 [Qemu-devel] [PATCH 0/8] Musicpal updates Jan Kiszka
2009-09-18 18:51 ` [Qemu-devel] [PATCH 1/8] musicpal: Catch null TX qeueues Jan Kiszka
2009-10-04 6:57 ` malc [this message]
2009-10-04 7:04 ` malc
2009-10-04 11:09 ` malc
2009-09-18 18:51 ` [Qemu-devel] [PATCH 7/8] musicpal: Make PIT emulation more robust Jan Kiszka
2009-09-18 18:51 ` [Qemu-devel] [PATCH 2/8] musicpal: Rework GPIO input events Jan Kiszka
2009-09-18 18:51 ` [Qemu-devel] [PATCH 4/8] musicpal: Coding style fixes Jan Kiszka
2009-09-18 18:51 ` [Qemu-devel] [PATCH 8/8] musicpal: Add VMState support Jan Kiszka
2009-09-18 18:51 ` [Qemu-devel] [PATCH 3/8] musicpal: Clean up typecasts Jan Kiszka
2009-09-18 18:51 ` [Qemu-devel] [PATCH 6/8] musicpal: True reset support for audio device Jan Kiszka
2009-09-18 18:51 ` [Qemu-devel] [PATCH 5/8] musicpal: True reset support for GPIO Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0910041054150.2134@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=jan.kiszka@web.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).