From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mvj3P-0006Pp-LG for qemu-devel@nongnu.org; Wed, 07 Oct 2009 22:48:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mvj3N-0006PW-QX for qemu-devel@nongnu.org; Wed, 07 Oct 2009 22:48:30 -0400 Received: from [199.232.76.173] (port=59509 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mvj3N-0006PM-GG for qemu-devel@nongnu.org; Wed, 07 Oct 2009 22:48:29 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:56827 helo=akado.ru) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mvj3N-0007R0-2l for qemu-devel@nongnu.org; Wed, 07 Oct 2009 22:48:29 -0400 Date: Thu, 8 Oct 2009 06:48:31 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread" In-Reply-To: <20091008014742.GA15601@shareable.org> Message-ID: References: <20091007132006.GA9668@redhat.com> <4ACCC1A5.5020306@codemonkey.ws> <20091007204421.GC4085@redhat.com> <20091007205523.GA4783@redhat.com> <20091008014742.GA15601@shareable.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jamie Lokier Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On Thu, 8 Oct 2009, Jamie Lokier wrote: > malc wrote: > > > The use of sigprocmask() is unspecified in a > > > multithreaded process; see pthread_sigmask(3). > > > > > > Does it matter? > > > > One of the patches i've asked you to try today replaced sigprocmask with > > pthread_sigmask, you've said it did nothing. In any case, strictly > > speaking, the code is wrong, so yes it does matter in theory. > > It won't matter on a Linux host (they are the same), but > pthread_sigmask should be used because it's Right(tm) and it could > make a difference on some other host. What made you think i'm of a different opinion? -- mailto:av1474@comtv.ru