From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MxRAh-0003uk-DS for qemu-devel@nongnu.org; Mon, 12 Oct 2009 16:07:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MxRAf-0003ti-Fo for qemu-devel@nongnu.org; Mon, 12 Oct 2009 16:07:06 -0400 Received: from [199.232.76.173] (port=35326 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MxRAf-0003tf-8l for qemu-devel@nongnu.org; Mon, 12 Oct 2009 16:07:05 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:64154 helo=akado.ru) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MxRAe-0004Sp-NN for qemu-devel@nongnu.org; Mon, 12 Oct 2009 16:07:04 -0400 Date: Tue, 13 Oct 2009 00:07:01 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [PATCH] tcg, tci: Add TCG and interpreter for bytecode (virtual machine) In-Reply-To: <20091012173942.GA11801@miranda.arrow> Message-ID: References: <4AC0E93A.6010605@mail.berlios.de> <1254156621-28559-1-git-send-email-weil@mail.berlios.de> <20091004182724.GA26105@miranda.arrow> <4AD208F5.9000203@mail.berlios.de> <20091011231735.GA10123@miranda.arrow> <20091012064652.GA10789@miranda.arrow> <20091012173942.GA11801@miranda.arrow> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stuart Brady Cc: qemu-devel@nongnu.org On Mon, 12 Oct 2009, Stuart Brady wrote: > On Mon, Oct 12, 2009 at 04:33:10PM +0400, malc wrote: > > On Mon, 12 Oct 2009, Stuart Brady wrote: > > > > > Huh? If you're using a function pointer with the *correct* type, > > > I hardly see how that's not sufficient. > > > > Let me give you an example: > > > [snip] > > *Mind boggles* :-) > > You seem to be ignoring the words "correct type" in all of my sentences. > My suggestion was to give op_call handling the information it that needs > iff TCI is used. Yes, the code in tcg_gen_callN() is clearly not > appropriate for TCI, although I'd somehow missed the fact that it may > also need to be changed in future to support other new TCG back-ends. > > I'm quite aware that functions must be invoked using the *correct type* > of function pointer, though. Perhaps I wasn't specific enough in what > I said, but please, I'm not completely clueless... :-) Are you thinking of a giant switch here, or what? -- mailto:av1474@comtv.ru