qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: malc <av1474@comtv.ru>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Build failure on mingw
Date: Mon, 16 Nov 2009 22:54:35 +0300 (MSK)	[thread overview]
Message-ID: <Pine.LNX.4.64.0911162251290.2277@linmac.oyster.ru> (raw)
In-Reply-To: <F1240511D87F4CE5A26F851035E0799B@FSCPC>

On Mon, 16 Nov 2009, Sebastian Herbszt wrote:

> malc wrote:
> > On Sat, 14 Nov 2009, Sebastian Herbszt wrote:

[..snip..]

> > 
> > Neither is/was correct, does escaping $@ in rules make (i.e. \$@) have
> > any effect?
> 
> Changing it to \$@ makes it compile again:
> 
> $ grep MMD rules.mak         QEMU_CFLAGS += -MMD -MP -MT \$@

[..snip..]

> gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed/slirp
> -Wold-style-definition
> -I. -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed -U_FORTIFY_SOURCE
> -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels
> -Wwrite-strings
> -Wmissing-prototypes -fno-strict-aliasing -m32 -DWIN32_LEAN_AND_MEAN
> -DWINVER=0x501 -MMD -MP -MT   -I/mingw/include/SDL -D_GNU_SOURCE=1
> -Dmain=SDL_main -O2 -g -c -o audio/sdlaudio.o audio/sdlaudio.c

[..snip..]

> 
> The only difference i notice are more spaces:
> -MMD -MP -MT -I/mingw/include/SDL
> vs.
> -MMD -MP -MT   -I/mingw/include/SDL
> 

Makefile has this:

sdl.o audio/sdlaudio.o sdl_zoom.o baum.o: QEMU_CFLAGS += $(SDL_CFLAGS)

Which, i guess, doesn't play well with expansion of $@ in rules.mak.
I wonder what changes you will see by adding following to the rules.mak.

QEMU_CFLAGS := $(QEMU_CFLAGS) -MMD -MP -MT $@

-- 
mailto:av1474@comtv.ru

  reply	other threads:[~2009-11-16 19:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-14 16:39 [Qemu-devel] Build failure on mingw Sebastian Herbszt
     [not found] ` <Pine.LNX.4.64.0911142108210.2712@linmac.oyster.ru>
2009-11-16 19:38   ` [Qemu-devel] " Sebastian Herbszt
2009-11-16 19:54     ` malc [this message]
2009-11-17 21:22       ` Sebastian Herbszt
2009-11-19 19:07         ` [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro) Stefan Weil
2009-11-19 20:13           ` [Qemu-devel] " Sebastian Herbszt
2009-11-19 21:32           ` malc
2009-11-20  6:40             ` Stefan Weil
2009-11-20  1:26           ` [Qemu-devel] " Jamie Lokier
2009-11-20  7:33             ` Stefan Weil
2009-11-20 14:55               ` Jamie Lokier
2009-11-20 18:26                 ` Stefan Weil
2009-11-20 16:58             ` Sebastian Herbszt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0911162251290.2277@linmac.oyster.ru \
    --to=av1474@comtv.ru \
    --cc=herbszt@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).