From: malc <av1474@comtv.ru>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl
Date: Thu, 14 Jan 2010 13:45:44 +0300 (MSK) [thread overview]
Message-ID: <Pine.LNX.4.64.1001141344480.2159@linmac.oyster.ru> (raw)
In-Reply-To: <4B4E77F6.1040205@redhat.com>
On Wed, 13 Jan 2010, Cole Robinson wrote:
> On 01/13/2010 07:11 PM, malc wrote:
> > On Wed, 13 Jan 2010, Cole Robinson wrote:
> >
> >> Current CDROM detection is hardcoded based on source file name.
> >> Make this smarter by attempting a CDROM specific ioctl.
> >>
> >> This makes '-cdrom /dev/sr0' succeed with no media present.
> >>
> >> v2:
> >> Give ioctl check higher priority than filename check,
> >>
> >> v3:
> >> Actually initialize 'prio' variable
> >> Check for ioctl success rather than absence of specific failure
> >
> > Does it even compile on BSDs, Darwin etc?
> >
>
> The changed functions are all under #ifdef __linux__, so I assume its fine.
> Haven't tested though.
Fine if so, it's not immediatelly aparent from the patches nor from
the commit messages though.
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2010-01-14 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 23:45 [Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl Cole Robinson
2010-01-14 0:11 ` malc
2010-01-14 1:48 ` Cole Robinson
2010-01-14 10:45 ` malc [this message]
2010-01-14 16:09 ` Cole Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1001141344480.2159@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=crobinso@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).