From: Brendan Fennell <bfennell@skynet.ie>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] pl190: fix read of VECTADDR
Date: Mon, 20 Aug 2012 20:51:46 +0100 (IST) [thread overview]
Message-ID: <Pine.LNX.4.64.1208202045280.9687@skynet.skynet.ie> (raw)
In-Reply-To: <CAFEAcA_zAcOu1MyvoYb+VLSYAr=pz0AvxhEOrF=mD+K-YFq4Wg@mail.gmail.com>
On Mon, 20 Aug 2012, Peter Maydell wrote:
> On 20 August 2012 18:59, Brendan Fennell <bfennell@skynet.ie> wrote:
>> Signed-off-by: Brendan Fennell <bfennell@skynet.ie>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> The () inside the [] aren't actually necessary, but I'm just
> going to fix those as I take this patch into the arm-devs
> queue, I think. I've also expanded the commit message a little:
>
> =====
> Reading VECTADDR was causing us to set the current priority to
> the wrong value, the most obvious effect of which was that we
> would return the vector for the wrong interrupt as the result
> of the read.
> =====
>
> What guest did you see this problem with? Since the QEMU 1.2
> release is now less than 2 weeks away, and this bug has been
> present since the versatilepb platform was added 6 years ago,
> I'm reluctant to squeeze it into this release unless it's
> going to be hit by a lot of people. (1.3 is only 3 months
> later so it's not a huge deal for a minor fix to miss 1.2.)
I'm working on a custom application, not a standard guest OS. I think it's
safe to say this can wait for 1.3.
Brendan.
>
> thanks
> -- PMM
>
>
prev parent reply other threads:[~2012-08-20 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 17:59 [Qemu-devel] [PATCH v3] pl190: fix read of VECTADDR Brendan Fennell
2012-08-20 18:11 ` Peter Maydell
2012-08-20 19:51 ` Brendan Fennell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1208202045280.9687@skynet.skynet.ie \
--to=bfennell@skynet.ie \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).