From: Klaus Jensen <its@irrelevant.dk>
To: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Damien Le Moal" <damien.lemoal@wdc.com>,
qemu-block@nongnu.org, "Niklas Cassel" <niklas.cassel@wdc.com>,
"Klaus Jensen" <k.jensen@samsung.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Keith Busch" <kbusch@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Matias Bjorling" <matias.bjorling@wdc.com>
Subject: Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set
Date: Fri, 8 Jan 2021 07:51:18 +0100 [thread overview]
Message-ID: <X/gA5nKm0s6ymCX6@apples.localdomain> (raw)
In-Reply-To: <X9Cfod3RaAOM9dJP@apples.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]
On Dec 9 10:57, Klaus Jensen wrote:
> Hi Dmitry,
>
> By and large, this looks OK to me. There are still some issues here and
> there, and some comments of mine that you did not address, but I will
> follow up with patches to fix that. Let's get this merged.
>
> It looks like the nvme-next you rebased on is slightly old and missing
> two commits:
>
> "hw/block/nvme: remove superfluous NvmeCtrl parameter" and
> "hw/block/nvme: pull aio error handling"
>
> It caused a couple of conflicts, but nothing that I couldn't fix up.
>
> Since I didn't manage to convince anyone about the zsze and zcap
> parameters being in terms of LBAs, I'll revert that to be
> 'zoned.zone_size' and 'zoned.zone_capacity'.
>
> Finally, would you accept that we skip "hw/block/nvme: Add injection of
> Offline/Read-Only zones" for now? I'd like to discuss it a bit since I
> think the random injects feels a bit ad-hoc. Back when I did OCSSD
> emulation with Hans, we did something like this for setting up state
> through a descriptor text file - I think we should explore something
> like that before we lock down the two parameters. I'll amend the final
> documentation commit to not include those parameters.
>
> Sounds good?
>
> Otherwise, I think this is mergeable to nvme-next. So, for the series
> (excluding "hw/block/nvme: Add injection of Offline/Read-Only zones"):
>
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
>
I've applied this series to my local nvme-next. Our repo host is
unavailable this morning (infradead.org), but I will push as soon as
possible.
Thanks!
Klaus
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-08 6:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 20:03 [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set Dmitry Fomichev
2020-12-08 20:03 ` [PATCH v11 01/13] hw/block/nvme: Process controller reset and shutdown differently Dmitry Fomichev
2020-12-08 20:03 ` [PATCH v11 02/13] hw/block/nvme: Generate namespace UUIDs Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 03/13] hw/block/nvme: Separate read and write handlers Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 04/13] hw/block/nvme: Combine nvme_write_zeroes() and nvme_write() Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 05/13] hw/block/nvme: Add Commands Supported and Effects log Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 06/13] hw/block/nvme: Add support for Namespace Types Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 07/13] hw/block/nvme: Support allocated CNS command variants Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 08/13] block/nvme: Make ZNS-related definitions Dmitry Fomichev
2020-12-09 6:37 ` Klaus Jensen
2020-12-15 16:28 ` Stefan Hajnoczi
2020-12-08 20:04 ` [PATCH v11 09/13] hw/block/nvme: Support Zoned Namespace Command Set Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 10/13] hw/block/nvme: Introduce max active and open zone limits Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 11/13] hw/block/nvme: Support Zone Descriptor Extensions Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 12/13] hw/block/nvme: Add injection of Offline/Read-Only zones Dmitry Fomichev
2020-12-08 20:04 ` [PATCH v11 13/13] hw/block/nvme: Document zoned parameters in usage text Dmitry Fomichev
2020-12-09 9:57 ` [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set Klaus Jensen
2020-12-10 19:25 ` Dmitry Fomichev
2020-12-11 6:37 ` Klaus Jensen
2021-01-08 6:51 ` Klaus Jensen [this message]
2020-12-16 0:23 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/gA5nKm0s6ymCX6@apples.localdomain \
--to=its@irrelevant.dk \
--cc=alistair.francis@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=dmitry.fomichev@wdc.com \
--cc=fam@euphon.net \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=matias.bjorling@wdc.com \
--cc=mreitz@redhat.com \
--cc=niklas.cassel@wdc.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).