From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F583C433FE for ; Tue, 8 Dec 2020 08:15:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 085BA23A51 for ; Tue, 8 Dec 2020 08:15:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 085BA23A51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yadro.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmY9e-0000jy-6L for qemu-devel@archiver.kernel.org; Tue, 08 Dec 2020 03:15:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmY6z-0007cz-VF for qemu-devel@nongnu.org; Tue, 08 Dec 2020 03:12:41 -0500 Received: from mta-02.yadro.com ([89.207.88.252]:47192 helo=mta-01.yadro.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmY6w-0007i5-88 for qemu-devel@nongnu.org; Tue, 08 Dec 2020 03:12:41 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 72840412DD; Tue, 8 Dec 2020 08:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received:received; s=mta-01; t=1607415155; x=1609229556; bh=RVyBMD4cqMg2GjhQnGK8JPbI29pUdLIX4vzUJfF1NKQ=; b= FDsa7gMh/7nIF0BRYgX7LutDxbWQdil+CqonAR58OLbktqVNnTsb+XeTy19L1fRB 9wMVVOl9X3xk44017M3KLWKhOMBus79vkAluJQIv/pE1K3oWhmhTw8zXBwHmbxae LF0+VjfSCdcWlRbEKDYFyPKp7M/vtwma9vKYhhnqexs= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZIkrezja5Jim; Tue, 8 Dec 2020 11:12:35 +0300 (MSK) Received: from T-EXCH-03.corp.yadro.com (t-exch-03.corp.yadro.com [172.17.100.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 61E2141256; Tue, 8 Dec 2020 11:12:35 +0300 (MSK) Received: from localhost (172.17.204.212) by T-EXCH-03.corp.yadro.com (172.17.100.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Tue, 8 Dec 2020 11:12:35 +0300 Date: Tue, 8 Dec 2020 11:13:07 +0300 From: Roman Bolshakov To: Peter Krempa Subject: Re: [PATCH for-6.0] accel: Wire accel to /machine Message-ID: References: <20201207084621.23876-1-r.bolshakov@yadro.com> <20201207173849.GC1289986@habkost.net> <20201207175007.GO105758@angien.pipo.sk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201207175007.GO105758@angien.pipo.sk> X-Originating-IP: [172.17.204.212] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-03.corp.yadro.com (172.17.100.103) Received-SPF: pass client-ip=89.207.88.252; envelope-from=r.bolshakov@yadro.com; helo=mta-01.yadro.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , libvir-list@redhat.com, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Richard Henderson , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Claudio Fontana , Paolo Bonzini , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Dec 07, 2020 at 06:50:07PM +0100, Peter Krempa wrote: > On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote: > > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote: > > > There's no generic way to query current accel and its properties via QOM > > > because there's no link between an accel and current machine. > > > > > > The change adds the link, i.e. if HVF is enabled the following will be > > > available in QOM: > > > > > > (qemu) qom-get /machine/accel type > > > "hvf-accel" > > > > > > Suggested-by: Markus Armbruster > > > Suggested-by: Paolo Bonzini > > > Signed-off-by: Roman Bolshakov > > > --- > > > > > > Hi, > > > > > > this is a follow up patch that deprecates earlier series [1]. > > > > > > > Is there a reference to the reasoning for dropping the earlier > > approach? Your previous approach seems preferable. > > The gist of the discussion before was that deprecating old commands in > the same release cycle as introducing the replacement might be > problematic if libvirt wants to adapt ASAP and that the new command > should be elevated to a intermediate tier of stability, where ACK from > libvirt is needed to change it during the same release cycle > incompatibly. > > That was meant generally for any command, and was started because we had > a similar issue recently. > > My intention definitely was not to change the patch itself, but more a > process change so that we can keep cooperating on new stuff rapidly, but > without actually breaking what we do. > Thanks Peter, I'll drop deprecation patch in v2 of query-accel QMP command. Ragards, Roman