From: Klaus Jensen <its@irrelevant.dk>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Keith Busch <kbusch@kernel.org>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v2] hw/nvme: Move NVMe emulation out of hw/block/ directory
Date: Mon, 30 Nov 2020 21:52:36 +0100 [thread overview]
Message-ID: <X8VblCummS/6aRMf@apples.localdomain> (raw)
In-Reply-To: <20201130145238.2509405-1-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]
On Nov 30 15:52, Philippe Mathieu-Daudé wrote:
> As IDE used to be, NVMe emulation is becoming an active
> subsystem. Move it into its own namespace.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Rebased after nvme-ns got merged in commit 8680d6e3646
> ---
> meson.build | 1 +
> hw/{block/nvme.h => nvme/nvme-internal.h} | 4 +-
> hw/{block => nvme}/nvme-ns.h | 0
> hw/{block/nvme.c => nvme/core.c} | 2 +-
> hw/{block => nvme}/nvme-ns.c | 0
> MAINTAINERS | 2 +-
> hw/Kconfig | 1 +
> hw/block/Kconfig | 5 -
> hw/block/meson.build | 1 -
> hw/block/trace-events | 132 ---------------------
> hw/meson.build | 1 +
> hw/nvme/Kconfig | 4 +
> hw/nvme/meson.build | 1 +
> hw/nvme/trace-events | 133 ++++++++++++++++++++++
> 14 files changed, 145 insertions(+), 142 deletions(-)
> rename hw/{block/nvme.h => nvme/nvme-internal.h} (98%)
> rename hw/{block => nvme}/nvme-ns.h (100%)
> rename hw/{block/nvme.c => nvme/core.c} (99%)
> rename hw/{block => nvme}/nvme-ns.c (100%)
Would we want to consider renaming nvme-ns.c to namespace.c? And maybe
also follow up with consolidating nvme-ns.h into nvme-internal.h?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-30 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 14:52 [PATCH v2] hw/nvme: Move NVMe emulation out of hw/block/ directory Philippe Mathieu-Daudé
2020-11-30 20:52 ` Klaus Jensen [this message]
2020-12-01 10:34 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8VblCummS/6aRMf@apples.localdomain \
--to=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).