From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BF52C64ED6 for ; Tue, 28 Feb 2023 11:44:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWyOu-0005zZ-CJ; Tue, 28 Feb 2023 06:44:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWyOf-0005og-0W for qemu-devel@nongnu.org; Tue, 28 Feb 2023 06:43:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWyOd-0006ac-GL for qemu-devel@nongnu.org; Tue, 28 Feb 2023 06:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677584630; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=ivVqPOV4yhgL4ARg0cO90lJkExEQYVYwqecefqQBn3k=; b=ExP+EIpUe0nWjZOxBsobH5agbZCcm5GDgcZO+soqJH4ifdTqopxbD1u4IK6KXPGvhbbVOe fu7eMzOe6nnrlbt/Np8/xpljiA+9xviVx6T+23IhxdTscivgxmBAKfw6nBPBcze06JMHqm G7/1d6ZD7JrXaEfA760c4THpjzbpKFQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-602-0TaMMffcMIeiHKxLwM65bQ-1; Tue, 28 Feb 2023 06:43:47 -0500 X-MC-Unique: 0TaMMffcMIeiHKxLwM65bQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30FBC85A5B1; Tue, 28 Feb 2023 11:43:47 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1CBC140EBF6; Tue, 28 Feb 2023 11:43:45 +0000 (UTC) Date: Tue, 28 Feb 2023 11:43:43 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Juan Quintela Cc: "John Berberian, Jr" , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Stefan Weil , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" Subject: Re: [PATCH v2] Fix exec migration on Windows (w32+w64). Message-ID: References: <20230116013421.3149183-1-jeb.study@gmail.com> <12107bdf-f631-e42a-5136-59bb67e301fc@gmail.com> <87pm9ukpti.fsf@secure.mitica> <87lekikopl.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87lekikopl.fsf@secure.mitica> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Feb 28, 2023 at 12:35:02PM +0100, Juan Quintela wrote: > Juan Quintela wrote: > > "John Berberian, Jr" wrote: > >> ping. Is there anything I can do to help this get merged? > > > > Hi > > > > I have to get back from Marc/Daniel before proceed. > > > > You did an answer, but they didn't respond. > > > > What should we do here? > > > > Thanks, Juan. > > Reviewed-by: Juan Quintela > > queued. > > Althought I would have preffer to create a > > os_get_cmd_path() > > in both os-win32.c and os-posix.c, so we don't have the #ifdefs at all. IMHO it is preferable to NOT have it in os-posix/win32 as we don't want any other areas of QEMU to mistakenly think it is a good idea to use. This will be relatively short lived once we introduce the new migration parameters to replace the URI, and can deprecate the use of shell. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|