From: "Daniel P. Berrangé" <berrange@redhat.com>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: mst@redhat.com, arei.gonglei@huawei.com, dgilbert@redhat.com,
pbonzini@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v5 08/12] cryptodev: Use CryptoDevBackendOpInfo for operation
Date: Wed, 1 Mar 2023 09:39:22 +0000 [thread overview]
Message-ID: <Y/8dSkEdL2vzTtuW@redhat.com> (raw)
In-Reply-To: <20230301025124.3605557-9-pizhenwei@bytedance.com>
On Wed, Mar 01, 2023 at 10:51:20AM +0800, zhenwei pi wrote:
> Move queue_index, CryptoDevCompletionFunc and opaque into struct
> CryptoDevBackendOpInfo, then cryptodev_backend_crypto_operation()
> needs an argument CryptoDevBackendOpInfo *op_info only. And remove
> VirtIOCryptoReq from cryptodev. It's also possible to hide
> VirtIOCryptoReq into virtio-crypto.c in the next step. (In theory,
> VirtIOCryptoReq is a private structure used by virtio-crypto only)
>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> backends/cryptodev-builtin.c | 9 +++------
> backends/cryptodev-lkcf.c | 9 +++------
> backends/cryptodev.c | 18 +++++-------------
> hw/virtio/virtio-crypto.c | 7 ++++---
> include/sysemu/cryptodev.h | 26 ++++++++++----------------
> 5 files changed, 25 insertions(+), 44 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-03-01 9:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 2:51 [PATCH v5 00/12] Refactor cryptodev zhenwei pi
2023-03-01 2:51 ` [PATCH v5 01/12] cryptodev: Introduce cryptodev.json zhenwei pi
2023-03-01 2:51 ` [PATCH v5 02/12] cryptodev: Remove 'name' & 'model' fields zhenwei pi
2023-03-01 2:51 ` [PATCH v5 03/12] cryptodev: Introduce cryptodev alg type in QAPI zhenwei pi
2023-03-01 2:51 ` [PATCH v5 04/12] cryptodev: Introduce server " zhenwei pi
2023-03-01 2:51 ` [PATCH v5 05/12] cryptodev: Introduce 'query-cryptodev' QMP command zhenwei pi
2023-03-01 9:36 ` Daniel P. Berrangé
2023-03-01 2:51 ` [PATCH v5 06/12] cryptodev-builtin: Detect akcipher capability zhenwei pi
2023-03-01 2:51 ` [PATCH v5 07/12] hmp: add cryptodev info command zhenwei pi
2023-03-01 9:38 ` Daniel P. Berrangé
2023-03-01 10:40 ` Dr. David Alan Gilbert
2023-03-01 10:47 ` Dr. David Alan Gilbert
2023-03-02 1:06 ` zhenwei pi
2023-03-01 2:51 ` [PATCH v5 08/12] cryptodev: Use CryptoDevBackendOpInfo for operation zhenwei pi
2023-03-01 9:39 ` Daniel P. Berrangé [this message]
2023-03-01 2:51 ` [PATCH v5 09/12] cryptodev: Account statistics zhenwei pi
2023-03-01 9:44 ` Daniel P. Berrangé
2023-03-01 10:20 ` zhenwei pi
2023-03-01 2:51 ` [PATCH v5 10/12] cryptodev: support QoS zhenwei pi
2023-03-01 9:45 ` Daniel P. Berrangé
2023-03-01 2:51 ` [PATCH v5 11/12] cryptodev: Support query-stats QMP command zhenwei pi
2023-03-01 9:13 ` Daniel P. Berrangé
2023-03-01 2:51 ` [PATCH v5 12/12] MAINTAINERS: add myself as the maintainer for cryptodev zhenwei pi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/8dSkEdL2vzTtuW@redhat.com \
--to=berrange@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).