qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, jsnow@redhat.com,
	peter.maydell@linaro.org, thuth@redhat.com,
	alex.bennee@linaro.org, armbru@redhat.com
Subject: Re: [PATCH 05/10] configure: Look for auxiliary Python installations
Date: Wed, 22 Feb 2023 15:19:40 +0000	[thread overview]
Message-ID: <Y/YyjEtqwF4qgAYc@redhat.com> (raw)
In-Reply-To: <20230222143752.466090-6-pbonzini@redhat.com>

On Wed, Feb 22, 2023 at 03:37:47PM +0100, Paolo Bonzini wrote:
> From: John Snow <jsnow@redhat.com>
> 
> At the moment, we look for just "python3" and "python", which is good
> enough almost all of the time. But ... if you are on a platform that
> uses an older Python by default and only offers a newer Python as an
> option, you'll have to specify --python=/usr/bin/foo every time.
> 
> We can be kind and instead make a cursory attempt to locate a suitable
> Python binary ourselves, looking for the remaining well-known binaries.
> 
> This configure loop will use whatever is specified in $PYTHON or, if
> empty, will try the following in order:
> 
> 1. python3
> 2. python
> 3. python3.11 down through python3.6
> 
> Notes:
> 
> - Python virtual environment provides binaries for "python3", "python",
>   and whichever version you used to create the venv,
>   e.g. "python3.8". If configure is invoked from inside of a venv, this
>   configure loop will not "break out" of that venv unless that venv is
>   created using an explicitly non-suitable version of Python that we
>   cannot use.
> 
> - In the event that no suitable python is found, the first python found
>   is the version used to generate the human-readable error message.
> 
> - The error message isn't printed right away to allow later
>   configuration code to pick up an explicitly configured python.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure | 63 ++++++++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 46 insertions(+), 17 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2023-02-22 15:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-22 14:37 [PATCH v4 0/9] improvement to Python detection, preparation for dropping 3.6 Paolo Bonzini
2023-02-22 14:37 ` [PATCH 01/10] python: support pylint 2.16 Paolo Bonzini
2023-02-22 14:37 ` [PATCH 02/10] python: drop pipenv Paolo Bonzini
2023-03-15 21:16   ` Philippe Mathieu-Daudé
2023-03-15 23:02     ` John Snow
2023-03-16  8:54       ` Philippe Mathieu-Daudé
2023-03-16 10:49         ` Jan Richter
2023-03-16 14:26         ` John Snow
2023-02-22 14:37 ` [PATCH 03/10] meson: prefer 'sphinx-build' to 'sphinx-build-3' Paolo Bonzini
2023-02-22 16:26   ` Markus Armbruster
2023-02-22 16:53     ` Paolo Bonzini
2023-02-22 14:37 ` [PATCH 04/10] configure: protect against escaping venv when running Meson Paolo Bonzini
2023-02-22 15:04   ` Daniel P. Berrangé
2023-02-22 15:25     ` Paolo Bonzini
2023-02-22 14:37 ` [PATCH 05/10] configure: Look for auxiliary Python installations Paolo Bonzini
2023-02-22 15:19   ` Daniel P. Berrangé [this message]
2023-02-22 14:37 ` [PATCH 06/10] lcitool: update submodule Paolo Bonzini
2023-02-22 15:07   ` Daniel P. Berrangé
2023-02-22 14:37 ` [PATCH 07/10] docs/devel: update and clarify lcitool instructions Paolo Bonzini
2023-02-22 15:11   ` Daniel P. Berrangé
2023-02-22 14:37 ` [PATCH 08/10] ci, docker: update CentOS and OpenSUSE Python to non-EOL versions Paolo Bonzini
2023-02-22 15:14   ` Daniel P. Berrangé
2023-02-22 14:37 ` [PATCH 09/10] Python: Drop support for Python 3.6 Paolo Bonzini
2023-02-22 15:16   ` Daniel P. Berrangé
2023-02-22 15:28     ` Paolo Bonzini
2023-02-22 16:31   ` Markus Armbruster
2023-02-22 17:02     ` Paolo Bonzini
2023-03-13 17:05   ` Daniel P. Berrangé
2023-03-15 12:53     ` Thomas Huth
2023-02-22 14:37 ` [PATCH 10/10] configure: Add courtesy hint to Python version failure message Paolo Bonzini
2023-03-21 14:11 ` [PATCH v4 0/9] improvement to Python detection, preparation for dropping 3.6 Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/YyjEtqwF4qgAYc@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).