From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D65F9C64ED6 for ; Mon, 27 Feb 2023 17:43:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWhWX-0004rx-9b; Mon, 27 Feb 2023 12:42:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWhWV-0004rp-Hj for qemu-devel@nongnu.org; Mon, 27 Feb 2023 12:42:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWhWT-0001tc-Lq for qemu-devel@nongnu.org; Mon, 27 Feb 2023 12:42:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677519768; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cenlVRSFdWOl2ZrghS5ylrQEc2wc7xoGUxckcL75P+A=; b=NWhFmMeEGSuO7hLQj3R16BBFds9RxK8oiUExjNHH2Q++uQsfWfdB6SkgqShIrvhrgJzK17 CYO089wIy0btI/XbmYL5dt8BIsxZjTTfW/oMt2aXxxBea9Yzw54jKs+bTeRItTkGGPqMLB 0QVHAWBPbX0koXBL3b2bVSPSFhMauFg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-59-n6M6ZzoTMcKnHpR3_CxC2w-1; Mon, 27 Feb 2023 12:42:43 -0500 X-MC-Unique: n6M6ZzoTMcKnHpR3_CxC2w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8D9E8857A81; Mon, 27 Feb 2023 17:42:37 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 03D52404BEC5; Mon, 27 Feb 2023 17:42:36 +0000 (UTC) Date: Mon, 27 Feb 2023 17:42:34 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Ross Lagerwall Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] ps2: Don't send key release event for Lang1, Lang2 keys Message-ID: References: <20230227173308.3944546-1-ross.lagerwall@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230227173308.3944546-1-ross.lagerwall@citrix.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Feb 27, 2023 at 05:33:08PM +0000, Ross Lagerwall wrote: > The scancodes for the Lang1 and Lang2 keys (i.e. Hangeul, Hanja) are > special since they already have the 0x80 bit set which is commonly used > to indicate a key release in AT set 1. Reportedly, real hardware does > not send a key release scancode. So, skip sending a release for these > keys. This ensures that Windows behaves correctly and interprets it as a > single keypress rather than two consecutive keypresses. A reference for this assertion would be: https://www.win.tue.nl/~aeb/linux/kbd/scancodes-9.html "The Korean keyboard has two keys, the Korean/Chinese and the Korean/English toggles, that generate scancodes f1 and f2 (respectively) when pressed, and nothing when released." > > Signed-off-by: Ross Lagerwall > --- > hw/input/ps2.c | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > index 3253ab6a92..45af76a837 100644 > --- a/hw/input/ps2.c > +++ b/hw/input/ps2.c > @@ -402,6 +402,9 @@ static void ps2_keyboard_event(DeviceState *dev, QemuConsole *src, > ps2_put_keycode(s, 0xaa); > } > } > + } else if ((qcode == Q_KEY_CODE_LANG1 || qcode == Q_KEY_CODE_LANG2) > + && !key->down) { > + /* Ignore release for these keys */ > } else { > if (qcode < qemu_input_map_qcode_to_atset1_len) { > keycode = qemu_input_map_qcode_to_atset1[qcode]; > @@ -497,6 +500,9 @@ static void ps2_keyboard_event(DeviceState *dev, QemuConsole *src, > ps2_put_keycode(s, 0x12); > } > } > + } else if ((qcode == Q_KEY_CODE_LANG1 || qcode == Q_KEY_CODE_LANG2) && > + !key->down) { > + /* Ignore release for these keys */ > } else { > if (qcode < qemu_input_map_qcode_to_atset2_len) { > keycode = qemu_input_map_qcode_to_atset2[qcode]; > -- > 2.31.1 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|