From: Peter Xu <peterx@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH v6 2/3] multifd: Protect multifd_send_sync_main() calls
Date: Wed, 15 Feb 2023 15:06:18 -0500 [thread overview]
Message-ID: <Y+07OqNDhKgPbsJ0@x1n> (raw)
In-Reply-To: <20230215180231.7644-3-quintela@redhat.com>
On Wed, Feb 15, 2023 at 07:02:30PM +0100, Juan Quintela wrote:
> We only need to do that on the ram_save_iterate() call on sending and
> on destination when we get a RAM_SAVE_FLAG_EOS.
>
> In setup() and complete() we need to synch in both new and old cases,
> so don't add a check there.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
[same issue on SoB]
Acked-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2023-02-15 20:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 18:02 [PATCH v6 0/3] Eliminate multifd flush Juan Quintela
2023-02-15 18:02 ` [PATCH v6 1/3] multifd: Create property multifd-flush-after-each-section Juan Quintela
2023-02-15 19:59 ` Peter Xu
2023-02-15 20:13 ` Juan Quintela
2023-02-16 15:15 ` Markus Armbruster
2023-02-16 17:13 ` Juan Quintela
2023-02-17 5:53 ` Markus Armbruster
2023-02-15 18:02 ` [PATCH v6 2/3] multifd: Protect multifd_send_sync_main() calls Juan Quintela
2023-02-15 20:06 ` Peter Xu [this message]
2023-02-15 18:02 ` [PATCH v6 3/3] multifd: Only flush once each full round of memory Juan Quintela
2023-02-15 20:05 ` Peter Xu
2023-02-16 11:00 ` Juan Quintela
2023-02-16 16:44 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+07OqNDhKgPbsJ0@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).