From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E71AC636CC for ; Thu, 16 Feb 2023 13:58:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSemN-0002ri-UB; Thu, 16 Feb 2023 08:58:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSemK-0002rH-PX for qemu-devel@nongnu.org; Thu, 16 Feb 2023 08:58:30 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSemI-0007rY-2X for qemu-devel@nongnu.org; Thu, 16 Feb 2023 08:58:27 -0500 Received: by mail-wm1-x335.google.com with SMTP id he5so1627238wmb.3 for ; Thu, 16 Feb 2023 05:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oOAF7Avv2m9okX26X1QQQBtkLpOUimdEi6kyPJqmGCU=; b=X8MUJWZE2HfktSgCL9+5gLsAMlD+Rs5Giu6vq+nuG5yGiNTlPEVkMMR+ZufVG5ls9+ +MujOMgT5HDyyWum3M+qOo0WYsV5aogNhapTj53CeOBS511Xkef1PvtIdUtdvDdQAiFo WhMV8lP6wCh2aefvvbbIGH6teSFBiIeX6XJOl842WrAM/s9wOJSaEAornDfQ8TEnylRm LVcFwa+CVpW8Bd6lXvMs12qA3C5b0gjeeW+3hCP/fvGkc8e2lCRClL/JvC59sua6xiXP TOQm3ai4oLn5oEBhI01oIiGZ+uo2b/PAdA3hp/G2YjqB7T0ysi8zgVcMMMvA+0NJm6Wz 7zOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oOAF7Avv2m9okX26X1QQQBtkLpOUimdEi6kyPJqmGCU=; b=XISVWUNXjkVpW+dM5/UzR2oMjlV1rA76GPgHtyH3xB2E69n3DSsqPUHDNl99ABkpyF eHkAaNfjgEdtwvV2brN4Q8P/TfRGrGBGqJro2Av3TjiYXUuzcKCERQkEUm641dpJlZb6 jrRIh1KvQUtRa56OiJ/aR+aqU+Igyk34cYMH5h6qoyLAMMJ9pg8zxjb/krtaqCI96XUT UpygwkzS+VO/n/akKl6nok9fij8JKVZ9JXiEEMUHgnOJjAbR2Mb6tqjLOpU5sUgtbS9f MRc/A+CNbIx7Ase4DLDWa0jKnmbAanDO+xIak2om+MrKYBQvMEsiD/7GQeraQ4E9Pw96 RDPQ== X-Gm-Message-State: AO0yUKWBptLgIf6v5d3GUMDvsst2Gmt9nyQOQieb2VvFfnPg894UxD8P qv7kj8oADOmTWt/Hld0tde8AlQ== X-Google-Smtp-Source: AK7set+MaeHxMa47nINFnVhSPAIR+kqzvWzAx7k9qUJcnEgcN+FpJRq3rjCUojRUlEmckihAG00WNw== X-Received: by 2002:a05:600c:3b1b:b0:3df:f3cb:e8ce with SMTP id m27-20020a05600c3b1b00b003dff3cbe8cemr174948wms.7.1676555904026; Thu, 16 Feb 2023 05:58:24 -0800 (PST) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id s10-20020a7bc38a000000b003dc1a525f22sm1779037wmj.25.2023.02.16.05.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 05:58:23 -0800 (PST) Date: Thu, 16 Feb 2023 13:58:19 +0000 From: Mostafa Saleh To: Eric Auger Cc: qemu-devel@nongnu.org, jean-philippe@linaro.org, peter.maydell@linaro.org, qemu-arm@nongnu.org Subject: Re: [RFC PATCH 13/16] hw/arm/smmuv3: Add CMDs related to stage 2 Message-ID: References: <20230205094411.793816-1-smostafa@google.com> <20230205094411.793816-14-smostafa@google.com> <7ebe5091-54ae-d5a2-09c4-0ae1e8276cb8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ebe5091-54ae-d5a2-09c4-0ae1e8276cb8@redhat.com> Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=smostafa@google.com; helo=mail-wm1-x335.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Eric, On Thu, Feb 16, 2023 at 12:56:52PM +0100, Eric Auger wrote: > > @@ -1174,14 +1174,35 @@ static int smmuv3_cmdq_consume(SMMUv3State *s) > > case SMMU_CMD_TLBI_NH_VA: > > smmuv3_s1_range_inval(bs, &cmd); > > break; > > + case SMMU_CMD_TLBI_S12_VMALL: > > + uint16_t vmid = CMD_VMID(&cmd); > > + > > + if (!STAGE2_SUPPORTED(s->features)) { > if you add such checks for S2, may you should consider adding similar > ones for existing S1? Yes, I will go through the other commands and do the same for stage-1 only commands. > > + smmu_inv_notifiers_all(&s->smmu_state); > > + smmu_iotlb_inv_vmid(bs, vmid); > > + break; > > + case SMMU_CMD_TLBI_S2_IPA: > > + if (!STAGE2_SUPPORTED(s->features)) { > > + cmd_error = SMMU_CERROR_ILL; > > + break; > > + } > > + /* > > + * As currently only either s1 or s2 are supported > > + * we can reuse same function for s2. > > + */ > > + smmuv3_s1_range_inval(bs, &cmd); > Shouldn't we rename the function then? I guess we can rename it smmuv3_s1_s2_range_inval, we will have to revisit this when nesting is supported. Thanks, Mostafa