From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org
Subject: Re: [RFC PATCH 4/4] ci, docker: update CentOS and OpenSUSE Python to non-EOL versions
Date: Wed, 8 Feb 2023 17:45:26 +0000 [thread overview]
Message-ID: <Y+PftgKNWUVHyyKq@redhat.com> (raw)
In-Reply-To: <20230117091638.50523-5-pbonzini@redhat.com>
On Tue, Jan 17, 2023 at 10:16:38AM +0100, Paolo Bonzini wrote:
> Python 3.6 is at end-of-life. Update the libvirt-ci module to a
> version that supports overrides for targets and package mappings;
> this way, QEMU can use the newer versions provided by CentOS 8 (Python
> 3.8) and OpenSUSE 15.3 (Python 3.9).
>
> One unexpected issue is that sphinx-rtd-theme does not want versions
> of docutils starting with 0.18. For distro-installed packages we can
> assume that the packager knew this, but when installing from PyPI the
> package version needs to be constrained by hand. In order to do this,
> add the docutils package explicitly to the qemu project file.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +-
> .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-
> .gitlab-ci.d/cirrus/macos-12.vars | 2 +-
> scripts/ci/setup/build-environment.yml | 2 +-
> tests/docker/dockerfiles/alpine.docker | 1 +
> tests/docker/dockerfiles/centos8.docker | 23 +++---
> .../dockerfiles/debian-amd64-cross.docker | 1 +
> tests/docker/dockerfiles/debian-amd64.docker | 1 +
> .../dockerfiles/debian-arm64-cross.docker | 1 +
> .../dockerfiles/debian-armel-cross.docker | 1 +
> .../dockerfiles/debian-armhf-cross.docker | 1 +
> .../dockerfiles/debian-mips64el-cross.docker | 1 +
> .../dockerfiles/debian-mipsel-cross.docker | 1 +
> .../dockerfiles/debian-ppc64el-cross.docker | 1 +
> .../dockerfiles/debian-s390x-cross.docker | 1 +
> .../dockerfiles/fedora-win32-cross.docker | 1 +
> .../dockerfiles/fedora-win64-cross.docker | 1 +
> tests/docker/dockerfiles/fedora.docker | 1 +
> tests/docker/dockerfiles/opensuse-leap.docker | 23 +++---
> tests/docker/dockerfiles/ubuntu2004.docker | 3 +-
> tests/lcitool/mappings.yml | 80 +++++++++++++++++++
> tests/lcitool/projects/qemu.yml | 1 +
> tests/lcitool/targets/centos-stream-8.yml | 3 +
> tests/lcitool/targets/opensuse-leap-153.yml | 3 +
> 24 files changed, 131 insertions(+), 26 deletions(-)
> create mode 100644 tests/lcitool/mappings.yml
> create mode 100644 tests/lcitool/targets/centos-stream-8.yml
> create mode 100644 tests/lcitool/targets/opensuse-leap-153.yml
Could you also update docs/devel/testing.rst where it talks
about lcitool, to give guidance about the local mappings/targets
overrides, vs the upstream mappings/targets usage. Most of the
time for new deps, we should continue to change the upstream
one, only using the local override where QEMU needs to diverge,
so that we maximise sharing.
The actual tests/ dir changes look ok to me
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-02-08 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 9:16 [RFC PATCH 0/4] Update CentOS and OpenSUSE CI to Python >=3.7 Paolo Bonzini
2023-01-17 9:16 ` [RFC PATCH 1/4] lcitool: update submodule Paolo Bonzini
2023-01-17 9:16 ` [RFC PATCH 2/4] lcitool: use libvirt-ci as library Paolo Bonzini
2023-02-08 17:27 ` Daniel P. Berrangé
2023-01-17 9:16 ` [RFC PATCH 3/4] lcitool: allow overriding package mappings and target facts Paolo Bonzini
2023-02-08 17:31 ` Daniel P. Berrangé
2023-01-17 9:16 ` [RFC PATCH 4/4] ci, docker: update CentOS and OpenSUSE Python to non-EOL versions Paolo Bonzini
2023-02-08 17:45 ` Daniel P. Berrangé [this message]
2023-02-08 17:22 ` [RFC PATCH 0/4] Update CentOS and OpenSUSE CI to Python >=3.7 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+PftgKNWUVHyyKq@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).