From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>,
Dorinda Bassey <dbassey@redhat.com>,
qemu-devel@nongnu.org, kraxel@redhat.com, armbru@redhat.com,
pbonzini@redhat.com, wtaymans@redhat.com
Subject: Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU
Date: Wed, 15 Feb 2023 15:08:20 +0000 [thread overview]
Message-ID: <Y+z1ZLftLF1RPirM@redhat.com> (raw)
In-Reply-To: <CAJ+F1CK6kCbhAbpK8dmS3qMHnRptJiiU-FeKy3qT2WjQUGyekQ@mail.gmail.com>
On Wed, Feb 15, 2023 at 06:11:12PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Feb 15, 2023 at 6:09 PM Christian Schoenebeck
> <qemu_oss@crudebyte.com> wrote:
> >
> > On Wednesday, February 15, 2023 2:18:50 PM CET Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey <dbassey@redhat.com> wrote:
> > > >
> > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as
> > both an audio sink and source. This backend is available on most systems.
> > > >
> > >
> > > Hmm, I would rather have less audio (and ui) backends in QEMU. (for
> > > audio, if I could introduce and keep only one, that would be
> > > GStreamer: to remove the others..)
> > >
> > > What is the main advantage compared to using the ALSA backend? (I
> > > assume pipewire depends on ALSA anyway on Linux)
> >
> > I think it does make sense to add Pipewire. Apparently it gains popularity.
>
> My point is that pipewire has ALSA plugin (and also pulseaudio compat
> library etc). So why add another back in QEMU?
Every layer in the stack has potential to impact the audio quality.
Even if its possible to wire up QEMU to pipewire via ALA/pulseaudio,
it wouldn't surprise me if its more reliable (in terms of avoiding
glitches/latency) to natively speak pipewire
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-02-15 15:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 8:51 [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU Dorinda Bassey
2023-02-15 11:26 ` Daniel P. Berrangé
2023-02-15 13:14 ` Dorinda Bassey
2023-02-16 10:33 ` Michael Tokarev
2023-02-16 10:47 ` Daniel P. Berrangé
2023-02-15 13:18 ` Marc-André Lureau
2023-02-15 14:08 ` Christian Schoenebeck
2023-02-15 14:11 ` Marc-André Lureau
2023-02-15 15:08 ` Daniel P. Berrangé [this message]
2023-02-15 15:09 ` Dorinda Bassey
2023-02-16 11:43 ` Gerd Hoffmann
2023-02-15 15:11 ` Gerd Hoffmann
2023-02-15 15:46 ` Dorinda Bassey
2023-02-15 15:59 ` Daniel P. Berrangé
2023-02-16 11:53 ` Christian Schoenebeck
-- strict thread matches above, loose matches on Subject: below --
2023-02-14 9:23 Dorinda Bassey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+z1ZLftLF1RPirM@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dbassey@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=wtaymans@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).